-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs/component-stability.md] Add criteria for graduating between stability levels #11864
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11864 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 448 448
Lines 23755 23755
=======================================
Hits 21757 21757
Misses 1623 1623
Partials 375 375 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Christos Markou <[email protected]>
3. Within the 30 days prior to the graduation request, the code owners MUST have reviewed and | ||
replied to at least 80% of the issues and pull requests opened against the component. This | ||
excludes general PRs or issues that are not specific to the component itself (e.g. repo-wide API | ||
updates). It is not necessary that the issues and PRs are closed or merged, but that they have | ||
been reviewed and replied to appropriately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is formalizing the existing practice and I agree with it.
## Beta to stable | ||
|
||
To graduate any signal from beta to stable on a component: | ||
1. The component MUST have at least three active code owners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a commitment from codeowners that there is a SLA for first response on bug issues.
The commitment should be measured in days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises some questions for me including:
- What happens when people go on vacation/have a kid/[insert activity here that leads to a prolonged period of absence]?
- What happens if people don't follow this SLA? Typically an SLA means that you pay if you don't meet a certain standard, how do you "pay" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't make it too hard to have community components.
I think vendor components and widely used components will not have any issue to follow the guidelines.
When we think about components that add value to the overall project, but may not be interesting/priority to vendors, they may struggle to get folks involved on it, and that would disqualify them from being moved to stable.
I do understand that we need to provide a way to ensure maintainability of stable components, but maybe we could draw something over the ideas of:
- Being active
- Replying to issues related to its components timely
- Fixing reported bug timely
- ...
If we have a component that is not vendor related, but maintained by 2 folks from a single employer, that wouldn't allow them to move on.
Also, let's imagine the following scenario:
- 3 folks are codeowners of a component, 2 from one company and another one from another company.
- They graduate to stable.
- A couple of months later the person that was from the other company moves to the same company of the other 2. Would the component be demoted?
I don't think it should be, if they are active and responsive in issues related to that component.
I know it is a corner case, and may never happen, but it still can.
My main point here, is actually that we shouldn't make it too hard to have community components.
I know a couple of companies that develop internal components to solve their customers' issues. It would be awesome to have a couple of those contributed back to upstream, and let the community grow together.
Description
Code ownership and maintenance of components continues to be an issue, with varying levels of support across contrib. As we approach 1.0 and the ability to mark components as stable, we want to make sure that components that we deem as 'stable' have a healthy community around them. We have three datapoints that we can leverage here: how many codeowners a component has, how diverse these are in terms of employers and how actively the codeowners have been responding to issues/PRs in the recent past.
We need criteria that
This excludes the
Some notes:
Link to tracking issue
Fixes #11850