[mdatagen]: require.Emptyf on config diff #11667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
mdatagen/testifier
branch
from
342d466 to
d697092
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11667 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 440 440
Lines 23755 23755
=======================================
Hits 21759 21759
Misses 1625 1625
Partials 371 371 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Nov 13, 2024
bogdandrutu
approved these changes
Nov 13, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
#### Description Uses require.Emptyf on config diff instead of testing.Error with diff not empty Signed-off-by: Matthieu MOREL <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
#### Description Uses require.Emptyf on config diff instead of testing.Error with diff not empty Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses require.Emptyf on config diff instead of testing.Error with diff not empty