[BREAKING CHANGE] Remove export_resource_labels flag from Zipkin exporter
#1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flands
requested review from
bogdandrutu,
dmitryax,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
- Coverage 86.89% 86.87% -0.02%
==========================================
Files 201 201
Lines 14524 14518 -6
==========================================
- Hits 12620 12612 -8
- Misses 1454 1456 +2
Partials 450 450
Continue to review full report at Codecov.
|
flands
changed the title
export_resource_labels flag from Zipkin exporterexport_resource_labels flag from Zipkin exporter
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…porter (open-telemetry#1163) Addresses open-telemetry#595 This flag was scheduled to be removed. Removing now.
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Recommend use of initializers for config structs Updates style guide and changes existing configure() implementations to newConfig() as appropriate. * Add CHANGELOG.md entry * Update stdout exporter config initializer * Add documentation to exported functions * Convert otlp.Config to unexported otlp.config
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #595