Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add text about unmaintained vendor components #11616

Merged

Conversation

TylerHelmuth
Copy link
Member

Description

This PR adds language to our definition of unmaintained that allows vendor-specific components to become unmaintained if they lose an active code owner from the contributing vendor. This is necessary to prevent a vendor-specific component form being maintained only by the community instead of by the vendor. Since vendors had privileged access to getting components accepted in contrib they must be held to a higher standard for maintaining those components.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner November 6, 2024 17:49
@atoulme
Copy link
Contributor

atoulme commented Nov 6, 2024

How do we know if a component is vendor-specific? Or maybe over time, do we want to no longer have any vendor-specific components?

@TylerHelmuth
Copy link
Member Author

How do we know if a component is vendor-specific? Or maybe over time, do we want to no longer have any vendor-specific components?

Good question. The git history/issues would have it, but right now it is probably relying more on the approvers/maintainers that were assigned as part of the rotation.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (b9ff1bc) to head (4194a54).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11616   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         447      447           
  Lines       23745    23745           
=======================================
  Hits        21712    21712           
  Misses       1657     1657           
  Partials      376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member

bogdandrutu commented Nov 6, 2024

Just to make is more interesting, is "datadogreceiver" vendor specific?

The git history/issues would have it, but right now it is probably relying more on the approvers/maintainers that were assigned as part of the rotation.

Can you tell me some "criterias" will you put to the history to determine this?

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Nov 6, 2024

@bogdandrutu I'd consider a component in contrib vendor-specific if during the component proposal process the vendor-specific checkbox was checked and the vendor-specific component label was used ((implying the vendor submitted the proposal) and it was accepted under the grounds of "yes we have to accept this so that we are playing fair with all vendors".

The datadogreceiver was not contributed under the above measures (and there are a few other components in contrib that touch vendor things but were not contributed by that vendor) so I would say it, and the others, are not vendor specific.

I think to merge this change it would be appropriate to classify the components in contrib that are subject to the additional guidelines this PR proposes. I could do that by adding something to the metadata.yaml for the components or by building some list somewhere that indicates the vendor-specific components contrib houses.

docs/component-stability.md Outdated Show resolved Hide resolved
docs/component-stability.md Show resolved Hide resolved
@atoulme
Copy link
Contributor

atoulme commented Nov 16, 2024

@TylerHelmuth please resolve conflicts

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me, conflicts need resolving though

@codeboten codeboten merged commit 4ed80bb into open-telemetry:main Dec 4, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 4, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…#11616)

#### Description

This PR adds language to our definition of `unmaintained` that allows
vendor-specific components to become unmaintained if they lose an active
code owner from the contributing vendor. This is necessary to prevent a
vendor-specific component form being maintained only by the community
instead of by the vendor. Since vendors had privileged access to getting
components accepted in contrib they must be held to a higher standard
for maintaining those components.

---------

Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants