Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated grpc config to use DialContext #11575

Merged
merged 9 commits into from
Nov 4, 2024
+27 −1
Merged

updated grpc config to use DialContext #11575

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cb94c42
updated configgrpc to use DialContext
akats7 Oct 30, 2024
45db51a
Merge branch 'main' into grpc-bug
akats7 Oct 30, 2024
6a1a807
added changelog for grpc client update
akats7 Oct 30, 2024
0edd5f3
typo in chlog
akats7 Oct 30, 2024
29d6e0a
Update config/configgrpc/configgrpc.go
songy23 Oct 31, 2024
507f0ff
Merge branch 'main' into grpc-bug
akats7 Oct 31, 2024
e7d3ca5
updated nolint
akats7 Nov 1, 2024
726d803
updated nolint comment
akats7 Nov 1, 2024
92e413e
updated nolint comment
akats7 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/configgrpc/configgrpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ func (gcs *ClientConfig) ToClientConn(
if err != nil {
return nil, err
}
return grpc.NewClient(gcs.sanitizedEndpoint(), grpcOpts...)
return grpc.DialContext(ctx, gcs.sanitizedEndpoint(), grpcOpts...)
akats7 marked this conversation as resolved.
Show resolved Hide resolved
songy23 marked this conversation as resolved.
Show resolved Hide resolved
}

func (gcs *ClientConfig) getGrpcDialOptions(
Expand Down
Loading