Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Small nits in batch processor, use generics to avoid type conversions #11501

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner October 21, 2024 17:59
@bogdandrutu bogdandrutu requested a review from mx-psi October 21, 2024 17:59
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.38%. Comparing base (4884781) to head (f24f54c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
processor/batchprocessor/batch_processor.go 87.01% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11501      +/-   ##
==========================================
- Coverage   91.41%   91.38%   -0.03%     
==========================================
  Files         433      433              
  Lines       23657    23659       +2     
==========================================
- Hits        21625    21620       -5     
- Misses       1658     1663       +5     
- Partials      374      376       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 8f20a07 into open-telemetry:main Oct 21, 2024
48 of 49 checks passed
@bogdandrutu bogdandrutu deleted the batch-generics branch October 21, 2024 23:21
@github-actions github-actions bot added this to the next release milestone Oct 21, 2024
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants