Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false fuzzer crash #11326

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

AdamKorcz
Copy link
Contributor

Description

The fuzzer report a null-pointer dereference which is not true. This fixes that.

Link to tracking issue

Fixes https://issues.oss-fuzz.com/issues/42538213

Testing

Documentation

Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz AdamKorcz requested a review from a team as a code owner October 1, 2024 16:16
@AdamKorcz AdamKorcz requested a review from songy23 October 1, 2024 16:16
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (1295083) to head (1fccd93).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11326   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         430      430           
  Lines       20242    20242           
=======================================
  Hits        18535    18535           
  Misses       1331     1331           
  Partials      376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 1, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any details of the report, can you add information here?
Screenshot 2024-10-01 at 11 29 25 AM

@AdamKorcz
Copy link
Contributor Author

I can't see any details of the report, can you add information here? Screenshot 2024-10-01 at 11 29 25 AM

The fuzzer runs into nil-dereference panic here because r.nextConsumer is nil:

err := r.nextConsumer.ConsumeMetrics(ctx, md)

@codeboten codeboten merged commit a24f914 into open-telemetry:main Oct 1, 2024
55 of 70 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 1, 2024
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
The fuzzer report a null-pointer dereference which is not true. This
fixes that.

#### Link to tracking issue
Fixes https://issues.oss-fuzz.com/issues/42538213

Signed-off-by: Adam Korczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants