[chore][graph] Separate node types #11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11321 +/- ##
=======================================
Coverage 91.43% 91.44%
=======================================
Files 424 430 +6
Lines 20270 20270
=======================================
+ Hits 18533 18535 +2
+ Misses 1360 1359 -1
+ Partials 377 376 -1 ☔ View full report in Codecov by Sentry. |
|
@djaglowski 100% agree. Do I remember asking you do to this? |
bogdandrutu
approved these changes
Oct 1, 2024
bogdandrutu
pushed a commit
that referenced
this pull request
Oct 1, 2024
This PR follows #11321 by splitting up the primary test file into a few related topics. I believe this will make further refactoring PRs easier to follow.
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
Having spent some time on open-telemetry#11311, I think it may be time to start refactoring this codebase into a more maintainable state. This PR just moves the various types of nodes into separate files, which I think is a bit more readable when considering changes.
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
This PR follows open-telemetry#11321 by splitting up the primary test file into a few related topics. I believe this will make further refactoring PRs easier to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having spent some time on #11311, I think it may be time to start refactoring this codebase into a more maintainable state. This PR just moves the various types of nodes into separate files, which I think is a bit more readable when considering changes.