Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate funcs that repeate processor in name #11310

Merged

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 30, 2024

Similar with #11287

@bogdandrutu bogdandrutu requested a review from a team as a code owner September 30, 2024 20:54
@bogdandrutu bogdandrutu force-pushed the deprecate-processor-name branch 2 times, most recently from 52183e7 to 0f78b3e Compare September 30, 2024 20:56
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (6412988) to head (d4c6777).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
processor/processor.go 57.89% 8 Missing ⚠️
processor/processorprofiles/processor.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11310      +/-   ##
==========================================
- Coverage   91.49%   91.43%   -0.07%     
==========================================
  Files         424      424              
  Lines       20240    20254      +14     
==========================================
  Hits        18519    18519              
- Misses       1344     1358      +14     
  Partials      377      377              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 98230db into open-telemetry:main Sep 30, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 30, 2024
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants