Refine scraperhelper.NewScraper to take component.Type directly #11082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11082 +/- ##
==========================================
- Coverage 92.21% 92.20% -0.01%
==========================================
Files 414 414
Lines 19728 19730 +2
==========================================
Hits 18193 18193
- Misses 1165 1167 +2
Partials 370 370 ☔ View full report in Codecov by Sentry. |
|
@mrasu Can you open a PR on https://github.com/open-telemetry/opentelemetry-collector-contrib to make all components use the new API? |
|
@mx-psi ok, I will |
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector
that referenced
this pull request
Sep 10, 2024
…-telemetry#11082) #### Description Create new function to enable to pass `component.Type` to `scraperhelper.NewScraper` Because many contrib scrapers name the scraper with the same name as the component itself, create a function to take `component.Type`. For example, https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/0e2bea5ac2763421e1a3943093f67184e109265f/receiver/activedirectorydsreceiver/factory_windows.go#L35 passes `metadata.Type.String()` as a name of scraper. With this change, you can pass `metadata.Type` instead <!-- Issue number if applicable --> #### Link to tracking issue Fixes open-telemetry#9473
|
Thanks to @djaglowski, optenetelemetry-collector-contrib use the new function now 😺 |
jburns24
added a commit
to liatrio/liatrio-otel-collector
that referenced
this pull request
Sep 10, 2024
adrielp
pushed a commit
to liatrio/liatrio-otel-collector
that referenced
this pull request
Sep 11, 2024
* Updated OpenTelemetry Collector modules for beta modules to 0.109.0 (core and contrib) and updated stable modules to 1.15.0 * Fixed linting violations caused by the deprication of scraperhelper.NewScraper open-telemetry/opentelemetry-collector#11082 Additionally added modules as `providers` in the ocb build configuration file. This resolved transative dependency issues when building the collector and issues reading config files. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Joshua Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new function to enable to pass
component.Typetoscraperhelper.NewScraperBecause many contrib scrapers name the scraper with the same name as the component itself, create a function to take
component.Type.For example, https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/0e2bea5ac2763421e1a3943093f67184e109265f/receiver/activedirectorydsreceiver/factory_windows.go#L35 passes
metadata.Type.String()as a name of scraper. With this change, you can passmetadata.TypeinsteadLink to tracking issue
Fixes #9473