[service/internal] Allow components to transition from PermanentError to Stopping #10958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
force-pushed
the
allow-permanent-to-stopping
branch
from
3c75b4c to
29263d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10958 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 447 447
Lines 23743 23745 +2
=======================================
+ Hits 21710 21712 +2
Misses 1657 1657
Partials 376 376 ☔ View full report in Codecov by Sentry. |
atoulme
approved these changes
Aug 26, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Pinging since the stalebot is engaging. |
mwear
force-pushed
the
allow-permanent-to-stopping
branch
from
29263d4 to
2bf1a58
Compare
TylerHelmuth
approved these changes
Oct 3, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Is there any chance this can be reopened? It was approved, but never merged. |
TylerHelmuth
added
ready-to-merge
atoulme
approved these changes
Dec 11, 2024
TylerHelmuth
requested review from
codeboten,
bogdandrutu,
mx-psi and
dmitryax
mx-psi
approved these changes
Dec 12, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
… to Stopping (open-telemetry#10958) #### Description In open-telemetry#10058 I mentioned: > There is a tangentially related issue with PermanentErrors and the underlying finite state machine that governs transitions between statuses. Currently, a PermanentError is a final state. That is, once a component enters this state, no further transitions are allowed. In light of the work I did on the alternative health check extension, I believe we should allow a transition from PermanentError to Stopping to consistently prioritize lifecycle events for components. This transition also make sense from a practical perspective. A component in a PermanentError state is one that has been started and is running, although in a likely degraded state. The collector will call shutdown on the component (when the collector is shutting down) and we should allow the status to reflect that. This PR makes the suggested change and updates the documentation to reflect that. As this is an internal change, I have not included a changelog. Also note, we can close open-telemetry#10058 after this as we've already removed status aggregation from core during the recent component status refactor. <!-- Issue number if applicable --> #### Link to tracking issue Fixes open-telemetry#10058 <!--Describe what testing was performed and which tests were added.--> #### Testing units <!--Describe the documentation added.--> #### Documentation Updated docs/component-status.md and associated diagram. <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #10058 I mentioned:
This PR makes the suggested change and updates the documentation to reflect that. As this is an internal change, I have not included a changelog. Also note, we can close #10058 after this as we've already removed status aggregation from core during the recent component status refactor.
Link to tracking issue
Fixes #10058
Testing
units
Documentation
Updated docs/component-status.md and associated diagram.