-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable filter processor as a default processor #1085
Enable filter processor as a default processor #1085
Conversation
I was planning on implementing a filter traceprocessor too, though I'm not sure of the best way to go about it now since the metric one needs to be on the old processor interfaces, and the trace one should use the new processor interfaces. But we can only have one "filter" type factory. Should I just implement the traceprocessor using the old interface for now and wait for new metrics processor interface to be ready to migrate them both? |
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 86.34% 86.33% -0.02%
==========================================
Files 198 198
Lines 14158 14159 +1
==========================================
- Hits 12225 12224 -1
- Misses 1477 1478 +1
- Partials 456 457 +1
Continue to review full report at Codecov.
|
@anniefu let me send a quick PR to transform metrics on the new interface. |
* Enable filter processor as a default processor * Fix test
…emetry#1085) Bumps golang from 1.17.5-stretch to 1.17.6-stretch. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description:
Add filter processor as a default processor.
Change trace processor to be old format so the filterprocessor correctly implements the old processor factory interface, otherwise there will be runtime errors.
Link to tracking Issue: part of #560
Testing: N/A
Documentation: N/A