Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filter processor as a default processor #1085

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

anniefu
Copy link
Contributor

@anniefu anniefu commented Jun 4, 2020

Description:
Add filter processor as a default processor.

Change trace processor to be old format so the filterprocessor correctly implements the old processor factory interface, otherwise there will be runtime errors.

Link to tracking Issue: part of #560

Testing: N/A

Documentation: N/A

@anniefu
Copy link
Contributor Author

anniefu commented Jun 4, 2020

I was planning on implementing a filter traceprocessor too, though I'm not sure of the best way to go about it now since the metric one needs to be on the old processor interfaces, and the trace one should use the new processor interfaces. But we can only have one "filter" type factory.

Should I just implement the traceprocessor using the old interface for now and wait for new metrics processor interface to be ready to migrate them both?

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #1085 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.02%     
==========================================
  Files         198      198              
  Lines       14158    14159       +1     
==========================================
- Hits        12225    12224       -1     
- Misses       1477     1478       +1     
- Partials      456      457       +1     
Impacted Files Coverage Δ
processor/filterprocessor/factory.go 100.00% <100.00%> (ø)
service/defaultcomponents/defaults.go 84.00% <100.00%> (+0.32%) ⬆️
translator/internaldata/resource_to_oc.go 73.52% <0.00%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975041a...e91c71f. Read the comment docs.

@bogdandrutu
Copy link
Member

@anniefu let me send a quick PR to transform metrics on the new interface.

@bogdandrutu bogdandrutu merged commit 9217573 into open-telemetry:master Jun 4, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
* Enable filter processor as a default processor

* Fix test
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…emetry#1085)

Bumps golang from 1.17.5-stretch to 1.17.6-stretch.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants