Deprecate expand converter #10723
Closed
Deprecate expand converter #10723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10723 +/- ##
==========================================
- Coverage 92.24% 92.22% -0.03%
==========================================
Files 403 403
Lines 18720 18717 -3
==========================================
- Hits 17268 17261 -7
- Misses 1097 1099 +2
- Partials 355 357 +2 ☔ View full report in Codecov by Sentry. |
dmitryax
reviewed
Jul 24, 2024
| @@ -36,6 +38,7 @@ func newConverter(set confmap.ConverterSettings) confmap.Converter { | |||
| } | |||
| } | |||
|
|
|||
| // Deprecated: [v0.105.0] BASH-style env var expansion is deprecated. Use `${FOO}` or `${env:FOO}` instead. | |||
There was a problem hiding this comment.
Let's first move the $$ escaping and ensure ${FOO} expansion without it?
There was a problem hiding this comment.
@dmitryax I was testing something, but I believe my original PR will be the one to go with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #
Testing
Documentation