Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Rename internal/featuregates to internal/globalgates #10614

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 15, 2024

Description

Fixes #10569. However, I think it's fine to just close the issue as wontfix and not do this.

@mx-psi mx-psi force-pushed the mx-psi/globalgates branch from efdb070 to ab9d5a2 Compare July 15, 2024 12:04
@mx-psi mx-psi marked this pull request as ready for review July 15, 2024 12:10
@mx-psi mx-psi requested review from a team and codeboten July 15, 2024 12:10
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (b3699f2) to head (ab9d5a2).

Files Patch % Lines
service/internal/proctelemetry/config.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10614      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files         395      395              
  Lines       18703    18703              
==========================================
+ Hits        17257    17259       +2     
+ Misses       1086     1085       -1     
+ Partials      360      359       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit 75aeab0 into open-telemetry:main Jul 15, 2024
57 of 67 checks passed
@mx-psi mx-psi deleted the mx-psi/globalgates branch July 15, 2024 14:11
@github-actions github-actions bot added this to the next release milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming internal/featuregates
2 participants