[mdatagen] Remove WithAttributes from the telemetry builder constructor #10608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
madatagen-allow-different-attributes
branch
3 times, most recently
from
91618e6
to
f72ae39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10608 +/- ##
==========================================
+ Coverage 92.27% 92.31% +0.03%
==========================================
Files 397 397
Lines 18729 18706 -23
==========================================
- Hits 17283 17268 -15
+ Misses 1086 1079 -7
+ Partials 360 359 -1 ☔ View full report in Codecov by Sentry. |
atoulme
approved these changes
Jul 16, 2024
Attribute sets for async instruments now can be set as options to callback setters and async instruments initializers. This allows each async instrument to have its own attribute set.
dmitryax
force-pushed
the
madatagen-allow-different-attributes
branch
from
f72ae39
to
72c916e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute sets for async instruments now can be set as options to callback setters and async instruments initializers. This allows each async instrument to have its own attribute set.
Unblocks #10593