Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Use string for unit type #10555

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/mdatagen/internal/samplereceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ metrics:
optional.metric:
enabled: false
description: "[DEPRECATED] Gauge double metric disabled by default."
unit: 1
unit: "1"
gauge:
value_type: double
attributes: [string_attr, boolean_attr]
Expand Down Expand Up @@ -155,7 +155,7 @@ telemetry:
batch_size_trigger_send:
enabled: true
description: Number of times the batch was sent due to a size trigger
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true
Expand All @@ -178,7 +178,7 @@ telemetry:
enabled: true
description: This metric is optional and therefore not initialized in NewTelemetryBuilder.
extended_documentation: For example this metric only exists if feature A is enabled.
unit: 1
unit: "1"
optional: true
gauge:
async: true
Expand Down
2 changes: 1 addition & 1 deletion cmd/mdatagen/testdata/invalid_type_attr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metrics:
metric:
enabled: true
description: Metric.
unit: 1
unit: "1"
gauge:
value_type: double
attributes: [used_attr]
2 changes: 1 addition & 1 deletion cmd/mdatagen/testdata/no_type_attr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ metrics:
metric:
enabled: true
description: Metric.
unit: 1
unit: "1"
gauge:
value_type: double
attributes: [used_attr]
2 changes: 1 addition & 1 deletion cmd/mdatagen/testdata/unused_attribute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ metrics:
metric:
enabled: true
description: Metric.
unit: 1
unit: "1"
gauge:
value_type: double
attributes: [used_attr]
22 changes: 11 additions & 11 deletions exporter/exporterhelper/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,79 +12,79 @@ telemetry:
exporter_sent_spans:
enabled: true
description: Number of spans successfully sent to destination.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_send_failed_spans:
enabled: true
description: Number of spans in failed attempts to send to destination.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_enqueue_failed_spans:
enabled: true
description: Number of spans failed to be added to the sending queue.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_sent_metric_points:
enabled: true
description: Number of metric points successfully sent to destination.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_send_failed_metric_points:
enabled: true
description: Number of metric points in failed attempts to send to destination.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_enqueue_failed_metric_points:
enabled: true
description: Number of metric points failed to be added to the sending queue.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_sent_log_records:
enabled: true
description: Number of log record successfully sent to destination.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_send_failed_log_records:
enabled: true
description: Number of log records in failed attempts to send to destination.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_enqueue_failed_log_records:
enabled: true
description: Number of log records failed to be added to the sending queue.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

exporter_queue_size:
enabled: true
description: Current size of the retry queue (in batches)
unit: 1
unit: "1"
optional: true
gauge:
value_type: int
Expand All @@ -93,7 +93,7 @@ telemetry:
exporter_queue_capacity:
enabled: true
description: Fixed capacity of the retry queue (in batches)
unit: 1
unit: "1"
optional: true
gauge:
value_type: int
Expand Down
8 changes: 4 additions & 4 deletions processor/batchprocessor/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@ telemetry:
processor_batch_batch_size_trigger_send:
enabled: true
description: Number of times the batch was sent due to a size trigger
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true
processor_batch_timeout_trigger_send:
enabled: true
description: Number of times the batch was sent due to a timeout trigger
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true
processor_batch_batch_send_size:
enabled: true
description: Number of units in the batch
unit: 1
unit: "1"
histogram:
value_type: int
bucket_boundaries: [10, 25, 50, 75, 100, 250, 500, 750, 1000, 2000, 3000, 4000, 5000, 6000, 7000, 8000, 9000, 10000, 20000, 30000, 50000, 100000]
Expand All @@ -42,7 +42,7 @@ telemetry:
processor_batch_metadata_cardinality:
enabled: true
description: Number of distinct metadata value combinations being processed
unit: 1
unit: "1"
sum:
value_type: int
async: true
24 changes: 12 additions & 12 deletions processor/processorhelper/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,95 +12,95 @@ telemetry:
processor_accepted_spans:
enabled: true
description: Number of spans successfully pushed into the next component in the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_refused_spans:
enabled: true
description: Number of spans that were rejected by the next component in the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_dropped_spans:
enabled: true
description: Number of spans that were dropped.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_inserted_spans:
enabled: true
description: Number of spans that were inserted.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_accepted_metric_points:
enabled: true
description: Number of metric points successfully pushed into the next component in the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_refused_metric_points:
enabled: true
description: Number of metric points that were rejected by the next component in the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_dropped_metric_points:
enabled: true
description: Number of metric points that were dropped.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_inserted_metric_points:
enabled: true
description: Number of metric points that were inserted.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_accepted_log_records:
enabled: true
description: Number of log records successfully pushed into the next component in the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_refused_log_records:
enabled: true
description: Number of log records that were rejected by the next component in the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_dropped_log_records:
enabled: true
description: Number of log records that were dropped.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

processor_inserted_log_records:
enabled: true
description: Number of log records that were inserted.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true
12 changes: 6 additions & 6 deletions receiver/receiverhelper/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,47 +12,47 @@ telemetry:
receiver_accepted_spans:
enabled: true
description: Number of spans successfully pushed into the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

receiver_refused_spans:
enabled: true
description: Number of spans that could not be pushed into the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

receiver_accepted_metric_points:
enabled: true
description: Number of metric points successfully pushed into the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

receiver_refused_metric_points:
enabled: true
description: Number of metric points that could not be pushed into the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

receiver_accepted_log_records:
enabled: true
description: Number of log records successfully pushed into the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

receiver_refused_log_records:
enabled: true
description: Number of log records that could not be pushed into the pipeline.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true
4 changes: 2 additions & 2 deletions receiver/scraperhelper/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ telemetry:
scraper_scraped_metric_points:
enabled: true
description: Number of metric points successfully scraped.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true

scraper_errored_metric_points:
enabled: true
description: Number of metric points that were unable to be scraped.
unit: 1
unit: "1"
sum:
value_type: int
monotonic: true
Loading