-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporterhelper] Fix incorrect deduplication of exporter queue metrics #10550
[exporterhelper] Fix incorrect deduplication of exporter queue metrics #10550
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10550 +/- ##
==========================================
- Coverage 92.35% 92.33% -0.03%
==========================================
Files 393 393
Lines 18622 18647 +25
==========================================
+ Hits 17199 17218 +19
- Misses 1066 1069 +3
- Partials 357 360 +3 ☔ View full report in Codecov by Sentry. |
Fix incorrect deduplication of otelcol_exporter_queue_size and otelcol_exporter_queue_capacity metrics if multiple exporters are used. Fixes open-telemetry#10444
6d7c360
to
77a0c9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we would need to unregister them properly.
@dmitryax the telemetryBuilder could hold a list of registrations that it could use to unregister? did you want to open a follow up issue for this?
Yes, but this also can become unnecessary if open-telemetry/opentelemetry-go#5561 is fixed. I'll create an issue to track it |
Fix incorrect deduplication of otelcol_exporter_queue_size and otelcol_exporter_queue_capacity metrics if multiple exporters are used.
Fixes #10444
The registered callbacks are ignored for now, which is the same behavior as before. Ideally, we would need to unregister them properly.