Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Fix incorrect deduplication of exporter queue metrics #10550

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jul 8, 2024

Fix incorrect deduplication of otelcol_exporter_queue_size and otelcol_exporter_queue_capacity metrics if multiple exporters are used.

Fixes #10444

The registered callbacks are ignored for now, which is the same behavior as before. Ideally, we would need to unregister them properly.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.33%. Comparing base (b127da0) to head (77a0c9e).

Files Patch % Lines
...terhelper/internal/metadata/generated_telemetry.go 66.66% 2 Missing and 2 partials ⚠️
...ereceiver/internal/metadata/generated_telemetry.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10550      +/-   ##
==========================================
- Coverage   92.35%   92.33%   -0.03%     
==========================================
  Files         393      393              
  Lines       18622    18647      +25     
==========================================
+ Hits        17199    17218      +19     
- Misses       1066     1069       +3     
- Partials      357      360       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix incorrect deduplication of otelcol_exporter_queue_size and otelcol_exporter_queue_capacity metrics if multiple exporters are used.

Fixes open-telemetry#10444
@dmitryax dmitryax force-pushed the fix-deduplication-queue-metrics-deduplication branch from 6d7c360 to 77a0c9e Compare July 8, 2024 14:29
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would need to unregister them properly.

@dmitryax the telemetryBuilder could hold a list of registrations that it could use to unregister? did you want to open a follow up issue for this?

@dmitryax
Copy link
Member Author

dmitryax commented Jul 8, 2024

@dmitryax the telemetryBuilder could hold a list of registrations that it could use to unregister? did you want to open a follow up issue for this?

Yes, but this also can become unnecessary if open-telemetry/opentelemetry-go#5561 is fixed. I'll create an issue to track it

@dmitryax dmitryax merged commit d545fb6 into open-telemetry:main Jul 8, 2024
39 of 53 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 8, 2024
@dmitryax dmitryax deleted the fix-deduplication-queue-metrics-deduplication branch July 9, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collector sending otelcol_exporter_queue_size metric on single exporter
4 participants