Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][VERSIONING.md] Changing protocol support for security is allowed #10460

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 24, 2024

Description

We have recently discussed bumping the minimum TLS version to follow security best practices.
Since we are about to stabilize configtls (see #10344), I raised the question of whether this would be a breaking change that should be done before 1.0.

I argue that we should be allowed to do this after 1.0 because:

  • The Go 1 version compatibility doc states

Security. A security issue in the specification or implementation may come to light whose resolution requires breaking compatibility. We reserve the right to address such security issues.

While this is not a security issue but a security best practice, the golang/go issue seems to indicate that changes like this would be in the spirit of the Go 1 version compatibility promise.

@mx-psi mx-psi requested review from a team, jpkrohling and codeboten June 24, 2024 09:08
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.46%. Comparing base (3364ba1) to head (9c57337).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10460   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         390      390           
  Lines       18461    18461           
=======================================
  Hits        17070    17070           
  Misses       1036     1036           
  Partials      355      355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit 2c15bfa into open-telemetry:main Jul 2, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants