Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelcol] Add featuregate to use stable expansion rules #10361

Conversation

TylerHelmuth
Copy link
Member

Description

This PR adds a feature gate to control all our use of the expandconverter. When enabled, the feature gate will use DefaultScheme="env" instead of the expandconverter for OCB and when supplying default providers in NewCommand.

Alternative to #10259

Link to tracking issue

Related to #10161
Related to #8215
Related to #7111

Testing

Unit tests

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.53%. Comparing base (a6ace53) to head (ce20c63).

Files Patch % Lines
otelcol/configprovider.go 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10361      +/-   ##
==========================================
- Coverage   92.54%   92.53%   -0.02%     
==========================================
  Files         387      387              
  Lines       18254    18258       +4     
==========================================
+ Hits        16894    16895       +1     
- Misses       1015     1016       +1     
- Partials      345      347       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth TylerHelmuth marked this pull request as draft June 10, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant