[exporterhelper] Fix shutdown hang on unstarted exporter #10313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10313 +/- ##
=======================================
Coverage 92.62% 92.63%
=======================================
Files 386 386
Lines 18236 18238 +2
=======================================
+ Hits 16892 16894 +2
Misses 1000 1000
Partials 344 344 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Jun 4, 2024
|
Thanks @carsonip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where shutdown hangs if batch_sender exporter is not started. The bug causes generated component tests to fail as well.
Link to tracking issue
Fixes #10306