[exporterhelper] Fix batch sender ignoring next senders in the chain #10287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-batch-sender-chaining
branch
from
37ba8f9 to
fb80363
Compare
dmitryax
force-pushed
the
fix-batch-sender-chaining
branch
from
fb80363 to
b0af83c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10287 +/- ##
==========================================
+ Coverage 92.62% 92.65% +0.02%
==========================================
Files 386 386
Lines 18236 18232 -4
==========================================
Hits 16892 16892
+ Misses 1000 996 -4
Partials 344 344 ☔ View full report in Codecov by Sentry. |
lahsivjar
reviewed
Jun 3, 2024
dmitryax
force-pushed
the
fix-batch-sender-chaining
branch
from
b0af83c to
92755ce
Compare
|
@lahsivjar @carsonip PTAL |
dmitryax
force-pushed
the
fix-batch-sender-chaining
branch
from
92755ce to
411834b
Compare
lahsivjar
approved these changes
Jun 4, 2024
carsonip
approved these changes
Jun 4, 2024
This change fixes a bug when the retry and timeout logic was not applied with enabled batching. The batch sender was ignoring the next senders in the chain.
dmitryax
force-pushed
the
fix-batch-sender-chaining
branch
from
f48bc1f to
1808a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when the retry and timeout logic was not applied with enabled batching. The batch sender was ignoring the next senders in the chain.
Fixes #10166