Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module client #9795

Closed
8 tasks done
Tracked by #9375
TylerHelmuth opened this issue Mar 19, 2024 · 4 comments · Fixed by #10775
Closed
8 tasks done
Tracked by #9375

Stabilize module client #9795

TylerHelmuth opened this issue Mar 19, 2024 · 4 comments · Fixed by #10775

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Mar 19, 2024

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases (regardless of when this issue was opened):

  • No open issues or PRs in the module that would require breaking changes
  • No TODOs in the module code that would require breaking changes
  • No deprecated symbols in the module
  • No symbols marked as experimental in the module
  • The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@mx-psi
Copy link
Member

mx-psi commented Mar 20, 2024

We would need to make client into a module on the first place 😄

@TylerHelmuth TylerHelmuth changed the title Stabilize module Client Stabilize module Client Mar 20, 2024
@TylerHelmuth TylerHelmuth changed the title Stabilize module Client Stabilize module client Mar 20, 2024
@atoulme
Copy link
Contributor

atoulme commented Mar 20, 2024

Does it need to be a module? Can it be moved under internal?

@TylerHelmuth
Copy link
Member Author

We would need to make client into a module on the first place 😄

I've been bitten by our template lol I want to be able to call this thing "stable" so that we can move forward with configgrpc and confighttp.

Does it need to be a module? Can it be moved under internal?

I don't believe so, it is used widely in Contrib.

@atoulme
Copy link
Contributor

atoulme commented Mar 21, 2024

#9804 is filed to follow up on creating the module.

mx-psi pushed a commit that referenced this issue Mar 27, 2024
**Description:** 
Removes the `experimental` tag from `Metadata`. This feature has been
used in the headerssetter extension since Aug 2022.

**Link to tracking Issue:** 
Relates to
#9381
Related to
#9795
@TylerHelmuth TylerHelmuth moved this to In Progress in Collector: v1 Apr 18, 2024
@mx-psi mx-psi closed this as completed in 7c2002a Aug 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Collector: v1 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants