Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: TestCreateTraceExporter flaky #59

Closed
pjanotti opened this issue Jun 25, 2019 · 2 comments · Fixed by #106
Closed

test: TestCreateTraceExporter flaky #59

pjanotti opened this issue Jun 25, 2019 · 2 comments · Fixed by #106
Assignees
@pjanotti
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@pjanotti
Copy link
Contributor

Failed once but passed other times, perhaps it is related to using Darwin instead of Linux

--- FAIL: TestCreateTraceExporter (0.37s)
    --- FAIL: TestCreateTraceExporter/Headers (0.00s)
        factory_test.go:145: 
                Error Trace:    factory_test.go:145
                Error:          Expected nil, but got: &status.statusError{Code:1, Message:"grpc: the client connection is closing", Details:[]*any.Any(nil), XXX_NoUnkeyedLiteral:struct {}{}, XXX_unrecognized:[]uint8(nil), XXX_sizecache:0}
                Test:           TestCreateTraceExporter/Headers
FAIL
FAIL    github.com/open-telemetry/opentelemetry-service/exporter/opencensusexporter     0.485s
@tigrannajaryan
Copy link
Member

I noticed this happening with TestCreateTraceExporter in the past and this failure is inherited from exporter tests which I copied from old implementation. Definitely needs fixing.

pjanotti referenced this issue in pjanotti/opentelemetry-service Jun 27, 2019
@odeke-em
cmd/ocagent: added version command
2962fe9 
Added a `version` command to the CLI which
will print out the information leading to when
and how the binary was built. The fields printed
out are:

* Version: The version of ocagent itself
* Goversion: The version of Go that compiled this binary
* OS: The OS it was built for (runtime.GOOS)
* Architecture: The architecture of the system
* GitHash: The hash of the ocagent commit

For example:
```shell
Version      0.0.1
GitHash      7ec3ea8
Goversion    devel +62e5215a2a Thu Oct 4 04:08:08 2018 +0000
OS           darwin
Architecture amd64
```

this will aid in:
* easy bug diagnoses and fixes
* plugin management whereby the exporter plugins MUST
match the version of Go that ocagent was built with inorder
for them to be application binary compatible
* reproducible builds

Also added a Makefile with a couple of directives
that allow for cross-compilation too.

Switched the flag parser from the inflexible "flag"
package in favour of "github.com/spf13/cobra".

Fixes #59
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jul 2, 2019
This was referenced Jul 3, 2019
Merged
Merged
@pjanotti pjanotti self-assigned this Jul 3, 2019
@pjanotti pjanotti mentioned this issue Jul 3, 2019
Merged
@pjanotti
Copy link
Contributor Author

Re-opening, hit again https://travis-ci.org/open-telemetry/opentelemetry-service/builds/563102924?utm_source=github_status&utm_medium=notification on PR #195

--- FAIL: TestCreateTraceExporter (1.99s)
    --- FAIL: TestCreateTraceExporter/UseSecure (0.81s)
        factory_test.go:167: 
            	Error Trace:	factory_test.go:167
            	Error:      	Expected nil, but got: &status.statusError{Code:1, Message:"grpc: the client connection is closing", Details:[]*any.Any(nil), XXX_NoUnkeyedLiteral:struct {}{}, XXX_unrecognized:[]uint8(nil), XXX_sizecache:0}
            	Test:       	TestCreateTraceExporter/UseSecure
FAIL

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@krnowak @rghetia
Make tag.Map a concrete type. (open-telemetry#89)
670b036 
This is to make tag.Map an immutable type, so it is safe to use
concurrently. The safety is not yet fully achieved because of the
functions returning contents of the map (Value and Foreach). The
functions give callers an access to core.Value objects, which contain
a byte slice, which has pointer like semantics. So to avoid accidental
changes, we will need to copy the value if it is of BYTES type.

Fixes open-telemetry#59
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jchengsfx
Update deps (open-telemetry#59)
c23b586 
* Update deps to v0.18.0

* go mod tidy

* Remove signalfx_correlation from configs and rename swap to paging

* Enable signalfx exporter for traces in configs

* smartagent: remove obsoleted InitEmpty() calls

Co-authored-by: Ryan Fitzpatrick <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@rnburn
Add backport of std::variant (open-telemetry#59)
176966a 
* Add varint files

* Fill out variant backport

* Add type_pack_element

* Add variant_size

* Add variant_alternative

* Fill out variant

* Fill out variant backport

* Fill out variant back port

* Fill out variant backport

* Fill out variant

* Fill out variant

* Add variant test

* Add get tests

* Add visit test

* Add more tests

* Fix variant tests

* Rename

* Reformat

* Add copyrights

* Add more variant tests

* Reformat

* Add more tests

* Fix for gcc-4.8

* Fix gcc-4.8 issue

* Rename macro

* Handle bools better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjanotti pjanotti

Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky TestCreateTraceExporter pjanotti/opentelemetry-service
2 participants
@tigrannajaryan @pjanotti