Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define semantic convention constants #435

Closed
tigrannajaryan opened this issue Nov 26, 2019 · 1 comment · Fixed by #438
Closed

Define semantic convention constants #435

tigrannajaryan opened this issue Nov 26, 2019 · 1 comment · Fixed by #438
Assignees
@kbrockhoff
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@tigrannajaryan
Copy link
Member

There are at least 2 pending PRs that define these conventions individually. There is a clear need for defining this and the best place to do it is in this repo so that it can be used by all components.

I suggest that the conventions are defined in a new translator/conventions/opentelemetry.go file.

Conventions to be defined: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/data-semantic-conventions.md
@tigrannajaryan tigrannajaryan added help wanted Good issue for contributors to OpenTelemetry Service to pick up up-for-grabs labels Nov 26, 2019
This was referenced Nov 26, 2019
Merged
Merged
@kbrockhoff
Copy link
Member

I am working on this.

@kbrockhoff kbrockhoff mentioned this issue Nov 29, 2019
Merged
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@krnowak @rghetia
Reword some function documentation in grpc plugin (open-telemetry#446)
437d9af 
Fixes open-telemetry#435.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot
Bump boto3 in /internal/buildscripts/packaging/release (open-telemetr…
a3e5278 
…y#435)

Bumps [boto3](https://github.com/boto/boto3) from 1.17.82 to 1.17.83.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.17.82...1.17.83)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@TylerHelmuth
[opentelemetry-operator] Fix collector image version (open-telemetry#435
03274a3 
)

Fixes the operator release which I broke by merging stuff too fast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbrockhoff kbrockhoff

Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define constants for semantic conventions attribute names
2 participants
@kbrockhoff @tigrannajaryan