Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NewExporterObsReport to accept Settings/Params instead of direct arguments #2643

Closed
bogdandrutu opened this issue Mar 9, 2021 · 0 comments · Fixed by #2668
Closed

Change NewExporterObsReport to accept Settings/Params instead of direct arguments #2643

bogdandrutu opened this issue Mar 9, 2021 · 0 comments · Fixed by #2668
Labels
area:miscellaneous good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
Phase2-Trace-GA-R...

Comments

@bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers area:miscellaneous labels Mar 9, 2021
@bogdandrutu bogdandrutu added this to the Phase1-GA-Roadmap milestone Mar 9, 2021
naseemkullah pushed a commit to naseemkullah/opentelemetry-collector that referenced this issue Mar 11, 2021
configure obsReport.NewExporter with struct
ccd6d99 
fixes open-telemetry#2643

Signed-off-by: naseemkullah <[email protected]>
@naseemkullah naseemkullah mentioned this issue Mar 11, 2021
Merged
naseemkullah pushed a commit to naseemkullah/opentelemetry-collector that referenced this issue Mar 19, 2021
configure obsReport.NewExporter with struct
d6e32ed 
fixes open-telemetry#2643

Signed-off-by: naseemkullah <[email protected]>
naseemkullah pushed a commit to naseemkullah/opentelemetry-collector that referenced this issue Mar 19, 2021
configure obsReport.NewExporter with struct
f68a94b 
fixes open-telemetry#2643

Signed-off-by: naseemkullah <[email protected]>
bogdandrutu pushed a commit that referenced this issue Mar 24, 2021
configure obsReport.NewExporter with struct (#2668)
9c14430 
fixes #2643

Signed-off-by: naseemkullah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:miscellaneous good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
Phase2-Trace-GA-Roadmap
Development

Successfully merging a pull request may close this issue.

configure obsReport.NewExporter with struct naseemkullah/opentelemetry-collector
1 participant
@bogdandrutu