Fix OTLP receiver Shutdown() bug #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2564 +/- ##
==========================================
- Coverage 91.71% 91.69% -0.03%
==========================================
Files 267 267
Lines 15107 15107
==========================================
- Hits 13856 13852 -4
- Misses 868 871 +3
- Partials 383 384 +1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
otlpshutdown
branch
from
5ad19b5 to
78e0c58
Compare
|
This is good, let's move forward with this. |
bogdandrutu
force-pushed
the
otlpshutdown
branch
from
78e0c58 to
d60dd7a
Compare
jpkrohling
reviewed
Mar 1, 2021
Ensure that the receiver finishes all ongoing requests, and does not accept any new request after shutdown is finished. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
otlpshutdown
branch
from
d60dd7a to
be06780
Compare
tigrannajaryan
approved these changes
Mar 1, 2021
|
Good job with the commit message :-) |
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the receiver finishes all ongoing requests, and does not accept any new request after shutdown is finished.
Signed-off-by: Bogdan Drutu [email protected]