Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: how to have a custom build and link to contrib repo #213

Closed
pjanotti opened this issue Jul 31, 2019 · 13 comments
Closed

Doc: how to have a custom build and link to contrib repo #213

pjanotti opened this issue Jul 31, 2019 · 13 comments
Assignees
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone

Comments

@pjanotti
Copy link
Contributor

We need to document how to have builds with custom sets of receivers/processors/exporters and link to contrib repo.

@tigrannajaryan tigrannajaryan added this to the Backlog milestone Jul 30, 2020
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jul 30, 2020
@jpkrohling
Copy link
Member

I'm planning on building an "opentelemetry-collector-builder", which would generate a binary based on a list of extra go modules as input. For that, I would certainly appreciate if someone could write a couple of paragraphs on the supported (or expected) way to have a custom build.

My understanding is that I would need to create an entrypoint (main()) that would get defaultcomponents.Components(), generates an component.ApplicationStartInfo, and creates a service.Parameters based on both. From there, all it needs is a service.New().Start(). Is that pretty much it ? If so, please assign this to me, and I'll create this doc as I go along.

@jpkrohling
Copy link
Member

The builder that I mentioned above could be used to address open-telemetry/opentelemetry-collector-contrib#873 and open-telemetry/opentelemetry-collector-contrib#35

@jpkrohling
Copy link
Member

I got a builder working. It's currently located in my own namespace, but I could move it to OpenTelemetry contrib if you think it's suitable: https://github.com/jpkrohling/opentelemetry-collector-builder .

@jpkrohling
Copy link
Member

Updated link to the repository: https://github.com/observatorium/opentelemetry-collector-builder

Should I use this as base for the doc? I could write a few lines about how to build a custom distribution and briefly mention the builder somewhere.

@kbrockhoff, once you figure out where the docs should go, we might know where to place this here as well.

@jpkrohling
Copy link
Member

@tigrannajaryan you can assign this to me.

@jpkrohling
Copy link
Member

@pjanotti, @tigrannajaryan, is it OK if I document this in a blog post first, until a decision about an appropriate home for the docs is made?

@tigrannajaryan
Copy link
Member

@pjanotti, @tigrannajaryan, is it OK if I document this in a blog post first, until a decision about an appropriate home for the docs is made?

Sounds good to me.

@jpkrohling
Copy link
Member

I tried pinging @SergeyKanzhelev and @mtwo on Gitter but got no replies yet. I really want to publish this in the OpenTelemetry publication, but in case it's not possible/desired, let me know and I'll find an alternative place.

@mtwo
Copy link
Member

mtwo commented Sep 23, 2020 via email

@SergeyKanzhelev
Copy link
Member

the process for the blog post is to send draft and request to join OpenTelemetry publication to [email protected]. This is a draft of how to do comms: https://docs.google.com/document/d/1tyy9SJw4ma7qGhjmJrNDBVC98qGxA1ssbYOJY2Jlok4/edit#heading=h.egqr4xhr9jrz - still in progress

@jpkrohling
Copy link
Member

Thanks for the doc, I'll follow it and propose a blog post. Is this already public information and I missed it?

@SergeyKanzhelev
Copy link
Member

Thanks for the doc, I'll follow it and propose a blog post. Is this already public information and I missed it?

It was never widely publicized. This doc is intended to do this. Last blog post was using this doc to validate it has enough info. Please share your feedback as well

@jpkrohling
Copy link
Member

Can this be closed? I think there's now a sufficient documentation about this (blog post + link from the doc).

@flands flands closed this as completed Feb 1, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
…elemetry#213)

* add RegisterSimpleSpanProcessor() modeled on stackdriver code

* update examples
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…ry#213)

Bumps [docker](https://github.com/docker/docker-py) from 4.3.1 to 4.4.4.
- [Release notes](https://github.com/docker/docker-py/releases)
- [Commits](docker/docker-py@4.3.1...4.4.4)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
* chore(ot-operator): update version to v0.51.0

* chore(crds): update collector crd

* chore(ghactions): update e2e tests workflow

* Update charts/opentelemetry-operator/crds/crd-opentelemetrycollector.yaml

Co-authored-by: Tyler Helmuth <[email protected]>

* Update charts/opentelemetry-operator/crds/crd-opentelemetrycollector.yaml

Co-authored-by: Tyler Helmuth <[email protected]>

Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

6 participants