-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlp receiver expects traces on “/v1/trace” but spec says “/v1/traces”. #1968
Comments
Signed-off-by: Bogdan Drutu <[email protected]>
I think this gets very ugly:
Probably it is good to proceed and change both gRPC, HTTP to use Here is a possible plan to do this in a backwards compatible way:
|
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change patches the gRPC gateway path pattern to match what spec requires. Fixes: open-telemetry#1968
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change patches the gRPC gateway path pattern to match what spec requires. Fixes: open-telemetry#1968
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change patches the gRPC gateway path pattern to match what spec requires. Fixes: open-telemetry#1968
@bogdandrutu I was initially thinking to keep gRPC unchanged for 2 reasons:
Because of the above 2 reasons I suggest that we don't change anything in OTLP/gRPC and keep it as is. We only fix the path in OTLP/HTTP. Here I was also initially thinking about a graceful, so that both paths are supported by receivers for a while, but now I think that even that is not necessary. OTLP/HTTP implementation was added to Collector just a few days ago, it is not even released. It is very likely that nobody in the wild is using this protocol yet so it should be OK to fix the bug without attempting to maintain compatibility with previous incorrect version of OTLP receiver. What do you think? |
I can look into implementing the fix for OTLP/HTTP in a graceful way, and keep accepting the old path in the receiver for a while, but it may complicate the fix. |
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: open-telemetry#1968
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: open-telemetry#1968
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: open-telemetry#1968
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: open-telemetry#1968
Fix for OTLP/HTTP only with graceful handling of both old and new path in OTLP receiver: #1979 |
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: open-telemetry#1968
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: #1968
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
* Add and enable loadtest for OTLP/HTTP Signed-off-by: Bogdan Drutu <[email protected]> * Fix path usage for otlphttp Signed-off-by: Bogdan Drutu <[email protected]> * Fix paths to handle wrong path for trace Signed-off-by: Bogdan Drutu <[email protected]> * Increase RAM usage for otlphttp trace test Signed-off-by: Bogdan Drutu <[email protected]> * Disable trace loadtests until #1968 gets resolved Signed-off-by: Bogdan Drutu <[email protected]> * Enable back OTLP-HTTP for trace Signed-off-by: Bogdan Drutu <[email protected]> * Fix review comments Signed-off-by: Bogdan Drutu <[email protected]> * Add changelog entry Signed-off-by: Bogdan Drutu <[email protected]>
This was changed 1y ago, and it is probably safe to remove it now. Updates open-telemetry#1968 Signed-off-by: Bogdan Drutu <[email protected]>
This was changed 1y ago, and it is probably safe to remove it now. Updates open-telemetry#1968 Signed-off-by: Bogdan Drutu <[email protected]>
This was changed 1y ago, and it is probably safe to remove it now. Updates #1968 Signed-off-by: Bogdan Drutu <[email protected]>
Probably need to fix this gracefully by adding “/v1/traces” as an alias, then removing “/v1/trace” in a few months after announcement.
The text was updated successfully, but these errors were encountered: