Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Span status translations to match the specification #1841

Closed
tigrannajaryan opened this issue Sep 23, 2020 · 0 comments · Fixed by open-telemetry/opentelemetry-collector-contrib#1489
Closed

Adjust Span status translations to match the specification #1841

tigrannajaryan opened this issue Sep 23, 2020 · 0 comments · Fixed by open-telemetry/opentelemetry-collector-contrib#1489
Assignees
@tigrannajaryan

Comments

@tigrannajaryan
Copy link
Member

Once this is merged open-telemetry/opentelemetry-specification#966 we need to adjust translation accordingly.
@tigrannajaryan tigrannajaryan added this to the GA 1.0 milestone Sep 23, 2020
@tigrannajaryan tigrannajaryan self-assigned this Oct 19, 2020
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Oct 29, 2020
Update OTLP to 0.6.0 and use the new Span Status code
415c639 
Contributes to open-telemetry#1841

TODO: need to use deprecated_code as specified in the OTLP spec.
@tigrannajaryan tigrannajaryan mentioned this issue Oct 29, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Oct 30, 2020
Update OTLP to 0.6.0 and use the new Span Status code
ced2bb8 
Contributes to open-telemetry#1841

TODO: need to use deprecated_code as specified in the OTLP spec.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Oct 30, 2020
Update OTLP to 0.6.0 and use the new Span Status code
306d6e3 
Contributes to open-telemetry#1841

TODO: need to use deprecated_code as specified in the OTLP spec.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
88190ba 
Contributes to open-telemetry#1841

TODO: need to use deprecated_code as specified in the OTLP spec.

Add sender-side handling of deprecated Span status code
Add receiver-side handling of deprecated Span status code
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
f008b97 
Contributes to open-telemetry#1841

TODO: need to use deprecated_code as specified in the OTLP spec.

Add sender-side handling of deprecated Span status code
Add receiver-side handling of deprecated Span status code
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
e8bd046 
Contributes to open-telemetry#1841

- Added tests that verify receiving and sending behavior for Status code.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
3909cde 
Contributes to open-telemetry#1841

- Added tests that verify receiving and sending behavior for Status code.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
a19b894 
Contributes to open-telemetry#1841

- Implemente the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
0d2d8bb 
Contributes to open-telemetry#1841

- Implemente the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
dccde5f 
Contributes to open-telemetry#1841

- Implemente the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
75f070a 
Contributes to open-telemetry#1841

- Implemented the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
05826e5 
Contributes to open-telemetry#1841

- Implemented the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Nov 3, 2020
Update OTLP to 0.6.0 and use the new Span Status code
e5e8508 
Contributes to open-telemetry#1841

- Implemented the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
tigrannajaryan added a commit that referenced this issue Nov 3, 2020
@tigrannajaryan
Update OTLP to 0.6.0 and use the new Span Status code (#2031)
de104da 
Contributes to #1841

- Implemented the backward compatibility logic for sending and receiving
  side for DeprecatedCode and Code fields according to OTLP spec.

- Had to modify pdata generator to allow generating fields without setters.
  This is needed because the Status code field needs a custom setter logic
  that implements the DeprecatedCode vs Code handling.

- Added tests that verify OTLP receiver behavior for Status Code/DeprecatedCode.

- Added tests that verify sending/setting behavior for Status Code/DeprecatedCode
  for any component that uses pdata.Traces Status.SetCode().

- Modified all non-OTLP trace receivers and exporters (Jaeger, Zipkin, OpenCensus) to use
  the new Status code.

- Modified correctness tests to use the new status Code instead of DeprecatedCode.
@tigrannajaryan tigrannajaryan mentioned this issue Nov 3, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector-contrib that referenced this issue Nov 4, 2020
Upgrade otel collector core, use the new Span Status code
eb024b4 
Resolves: open-telemetry/opentelemetry-collector#1841

This uses the new Span Status Code/DeprecatedCode from core repo.

Changes to Span Status are described in more details in this core PR:
open-telemetry/opentelemetry-collector#2031
tigrannajaryan added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Nov 5, 2020
@tigrannajaryan
Upgrade otel collector core, use the new Span Status code (#1489)
0e912e6 
Resolves: open-telemetry/opentelemetry-collector#1841

This uses the new Span Status Code/DeprecatedCode from core repo.

Changes to Span Status are described in more details in this core PR:
open-telemetry/opentelemetry-collector#2031
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@pellared @MrAlias
Refine configuration design docs (open-telemetry#1841)
392a44f 
* Refine configuration design docs

* Remove repetition

* Fix typo

* Unify code blocks

Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tigrannajaryan