Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Prometheus remote write exporter to use the new internal metrics structs #1681

Closed
bogdandrutu opened this issue Aug 30, 2020 · 6 comments · Fixed by #1708
Closed

Change Prometheus remote write exporter to use the new internal metrics structs #1681

bogdandrutu opened this issue Aug 30, 2020 · 6 comments · Fixed by #1708
Assignees
@huyan0
Labels
enhancement New feature or request

Comments

@bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu changed the title Change Prometheus remote write exporter to use the new internal metrics structa Change Prometheus remote write exporter to use the new internal metrics structs Aug 30, 2020
@huyan0 huyan0 mentioned this issue Aug 31, 2020
Merged
@huyan0
Copy link
Member

huyan0 commented Aug 31, 2020 •
edited
Loading

Hi @bogdandrutu, Should I convert from data.MetricsData or convert from the underlying v0.5 OTLP data? I ask because I remember you saying last Thursday that more change will happen to this current version of OTLP, and using data.MetricsData would hide those changes from the exporter. Is this correct?

@bogdandrutu
Copy link
Member Author

You should change to use:
dataold.MetricsData -> data.MetricsData
pdatautil.*OldInternal* -> pdatautil.*Internal*
testdataold -> testdata (prefix was changed GenerateMetricData -> GenerateMetrics)

@huyan0
Copy link
Member

huyan0 commented Aug 31, 2020

You should change to use:
dataold.MetricsData -> data.MetricsData
pdatautil.*OldInternal* -> pdatautil.*Internal*
testdataold -> testdata (prefix was changed GenerateMetricData -> GenerateMetrics)

Okay, sounds good. Thanks.

@bogdandrutu bogdandrutu reopened this Sep 1, 2020
@bogdandrutu
Copy link
Member Author

Don't know why this issue got closed probably I pressed random buttons :))

@bogdandrutu
Copy link
Member Author

@huyan0 are you working on this?

@huyan0
Copy link
Member

huyan0 commented Sep 1, 2020

@huyan0 are you working on this?

Yeah I have the code. will file a PR today

@huyan0 huyan0 mentioned this issue Sep 1, 2020
Merged
@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@matej-g @MrAlias
Span status from HTTP code: Do not set status message if it can be in…
58f69f0 
…ferred (open-telemetry#1681)

* Do not set status message if reason can be inferred

* Update CHANGELOG

* Add comment on validation func

Co-authored-by: Tyler Yahn <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot
Bump boto3 in /internal/buildscripts/packaging/release (open-telemetr…
813c46d 
…y#1681)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.7 to 1.24.8.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.7...1.24.8)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huyan0 huyan0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor the Prometheus remote write exporter to use OTLP v0.5.0 open-o11y/opentelemetry-collector
3 participants
@andrewhsu @bogdandrutu @huyan0