Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Stricter Golint check. #155

Closed
songy23 opened this issue Jul 15, 2019 · 0 comments · Fixed by #218
Closed

all: Stricter Golint check. #155

songy23 opened this issue Jul 15, 2019 · 0 comments · Fixed by #218
Assignees
@songy23

Comments

@songy23
Copy link
Member

songy23 commented Jul 15, 2019

We currently have a lint check in the Makefile. However this check is not very strict, for example it doesn't check package documentations. This has caused a bit trouble when we tried to use the otel-svc code when a stricter lint check is enforced. Consider doing a stricter Golint check in the CI.
@songy23 songy23 mentioned this issue Jul 16, 2019
Merged
@songy23 songy23 self-assigned this Jul 30, 2019
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 30, 2019
@songy23
Add goimports check and fix import order for all files
6656da7 
Updates open-telemetry#155.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 30, 2019
@songy23
Add goimports check and fix import order for all files
28bf4bd 
Updates open-telemetry#155.
@songy23 songy23 mentioned this issue Jul 30, 2019
Merged
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add misspell check and fix all typos
14bad53 
Updates open-telemetry#155.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add goimports check and fix import order for all files
e6da23a 
Updates open-telemetry#155.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add goimports check and fix import order for all files
69384a3 
Updates open-telemetry#155.
pjanotti pushed a commit that referenced this issue Jul 31, 2019
@songy23
Add goimports check and fix import order for all files (#209)
c7eacad 
* Add goimports check and fix import order for all files

Updates #155.

* Try specifying a version for goimports

* Show the diff instead of files and fix import

* Fix default in Makefile
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add misspell check and fix all typos
c695367 
Updates open-telemetry#155.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add misspell check and fix all typos
037f7fb 
Updates open-telemetry#155.
@songy23 songy23 mentioned this issue Jul 31, 2019
Merged
pjanotti pushed a commit that referenced this issue Jul 31, 2019
@songy23
Add misspell check and fix all typos (#214)
dc4266d 
* Add misspell check and fix all typos

Updates #155.

* Format

* Include yaml files
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add static check
1460949 
Fixes open-telemetry#155.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 1, 2019
@songy23
Add static check
c53fea9 
Fixes open-telemetry#155.
@songy23 songy23 mentioned this issue Aug 1, 2019
Merged
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 1, 2019
@songy23
Add static check
22502fb 
Fixes open-telemetry#155.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 1, 2019
@songy23
Add static check
cae899f 
Fixes open-telemetry#155.
pjanotti pushed a commit that referenced this issue Aug 2, 2019
@songy23
Add static check and fix all errors (#218)
79957ff 
* Add static check

Fixes #155.

* Fix most staticcheck errors

* More fixes

* Fix id_batcher
pjanotti pushed a commit that referenced this issue Aug 7, 2019
@dinooliva
Migrate updates to Prometheus receiver from opencensus-service (#208)
22b9a57 
* Migrate updates to Prometheus receiver from opencensus-service

* Remove unnecessary configuration for adjusting metrics

* Update exporters README (#210)

Remove stale content, put in place a simple skeleton, and put information for the Zipkin exporter.

* Added Jaeger gRPC receiver (#197)

* Added Jaeger gRPC receiver

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Addressed first review round

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Changes based on the feedback from the second review

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Fixed import order, check for same ip:port on endpoints

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Reverted the port-check

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* Fix README - remove broken links and commands (#211)

Signed-off-by: Hui Kang <[email protected]>

* Refactor opencensus exporter to make it easily extensible (#212)

Refactored oc exporter code to make it easier to import in derived
builds without copying all the code.

Example derived exporter: https://github.com/owais/example-derived-oc-exporter

- Moved internal/compression to root
- Split opencensusexporter factory's `CreateTraceExporter` method into
  - `OCAgentOptions` and `CreateOCAgent`

* Use sha256 instead of md5 in node batcher processor (#202)

MD5 is insecure cryptographic hash functions, and are therefore unsuitable for security applications.

* Add goimports check and fix import order for all files (#209)

* Add goimports check and fix import order for all files

Updates #155.

* Try specifying a version for goimports

* Show the diff instead of files and fix import

* Fix default in Makefile

* Add factory and update config for tail sampling processor (#200)

* Add factory and update config for tail sampling processor

Updates #146

* Move to package processor

* Remove an unnecessary check

* Move CreateDefaultConfig to factory and add unit tests

* Fix test failure

* Remove commented code

* Add misspell check and fix all typos (#214)

* Add misspell check and fix all typos

Updates #155.

* Format

* Include yaml files

* Move tail sampling config to its own package and remove stale configs (#217)

Follow up of #200. Second step of #146.

* Add Observability Vision document (#188)

* Add Observability Vision document

This is a guidance document that developers can consult with when
working on improving own observability of OpenTelemetry Service.

* PR fixes

* Add Zipkin exporter factory (#207)

* Add Zipkin exporter factory

Add the Zipkin exporter configuration factory using the new configuration format. This does not bring many of the settings from the old configuration since they won't be used. In a sub-sequent PR the code of the exporter itself will be changed.

* PR Feedback: add 1 test plus some comments

* Rename endpoint to http-url and related field

* Fix goimports issue

* Remove TODO commented code

Replaced the TODO commented code with an issue.

* Rename the field used to specify destination

* Update README to address reviewer comments.

* Update module dependencies and import order for metricfamily

* Improve OC Receiver Documentation (#203)

* First round of receiver and opencensus receiver documentation.

* Undo go mod/sum changes

* Address initial set of comments.

* Address next set of comments.

* Address next set of comments.

* Fix use of server instead of receiver in comment and explain settings can be mix and matched.

* Merged master and fixed mispell error caugh with new tools

* Add static check and fix all errors (#218)

* Add static check

Fixes #155.

* Fix most staticcheck errors

* More fixes

* Fix id_batcher

* Rename exporterhelp parameter (#220)

The paramater was named exportFormat but it actually used as the exporter name.

* Fix build: lower casing error message (#224)

* Add jaeger grpc exporter (#219)

* Add Jaeger gRPC exporter

Adds a Jaeger gRPC exporter.

* Update exporters/README.md

* Fixes on the exporter/README.md

* Add doc.go with package description.

* Fix import order on config_test.go

* Migrate updates to Prometheus receiver from opencensus-service

* Remove unnecessary configuration for adjusting metrics

* Update README to address reviewer comments.

* Update module dependencies and import order for metricfamily

* Fix goimports

* Fix staticcheck issues
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@rghetia
add binary propagation. (open-telemetry#155)
211007e
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jeffreyc-splunk
Release v0.22.0 (open-telemetry#155)
ed2f46c 
* Adopt ServiceExtension rename from Collector core 7cdbd1c

* Adopt other Collector core breaking changes

* Update integration test deps

* fieldalignment fixes

* Release v0.22.0

Co-authored-by: Ryan Fitzpatrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@songy23 songy23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add static check and fix all errors songy23/opentelemetry-service
1 participant
@songy23