Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span Kind data loss in OpenCensus protocol #1136

Closed
kbrockhoff opened this issue Jun 18, 2020 · 1 comment
Closed

Span Kind data loss in OpenCensus protocol #1136

kbrockhoff opened this issue Jun 18, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
Beta 0.6.0

Comments

@kbrockhoff
Copy link
Member

Describe the bug
OpenCensus protocol only defines Unknown, Client and Server span kinds. When translating between OTLP protocol and OpenCensus protocol this results in data loss because other Kind values get translated to Unknown.

Steps to reproduce
Run the tracing correctness tests and view the results summary.

What did you expect to see?
Zero failure count.

What did you see instead?
Failure count of 296 and failures: Kind,1!=0,count=296;.

What version did you use?
Version: (e.g., v0.4.0, 1eb551b, etc)

What config did you use?
Correctness test configuration per receiver-exporter combination.

Environment
OS: OS X
Compiler(if manually compiled): go1.14.3 darwin/amd64

Additional context
@kbrockhoff kbrockhoff added the bug Something isn't working label Jun 18, 2020
This was referenced Jun 18, 2020
Closed
Closed
Closed
@tigrannajaryan
Copy link
Member

Supposedly this should be handled by

opentelemetry-collector/translator/internaldata/traces_to_oc.go

Line 174 in e3df9f3

func spanKindToOCAttribute(kind pdata.SpanKind) *octrace.AttributeValue {
and

opentelemetry-collector/translator/internaldata/oc_to_traces.go

Line 239 in e3df9f3

case octrace.Span_SPAN_KIND_UNSPECIFIED:

But apparently it is not.

@kbrockhoff kbrockhoff mentioned this issue Jun 18, 2020
Merged
@flands flands added this to the GA 1.0 milestone Jun 18, 2020
tigrannajaryan pushed a commit that referenced this issue Jun 22, 2020
@kbrockhoff
Fix handling of SpanKind INTERNAL in OTLP OC translation (#1143)
9f1c0cb 
Added setting of span attribute "span.kind" to "internal" when translating from OTLP to OC and translate back to SpanKindINTERNAL when translating from OC to OTLP.

**Link to tracking Issue:** #1136 #754

**Testing:** All tracing correctness tests involving only otlp and opencensus receivers and exporters now report a zero failure count.
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this issue Jul 13, 2020
@kbrockhoff @wyTrivail
Fix handling of SpanKind INTERNAL in OTLP OC translation (open-teleme…
96d9480 
…try#1143)

Added setting of span attribute "span.kind" to "internal" when translating from OTLP to OC and translate back to SpanKindINTERNAL when translating from OC to OTLP.

**Link to tracking Issue:** open-telemetry#1136 open-telemetry#754

**Testing:** All tracing correctness tests involving only otlp and opencensus receivers and exporters now report a zero failure count.
@flands flands modified the milestones: GA 1.0, Beta 0.6.0 Jul 16, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@rakyll @MrAlias
Add receiver names to TraceContext methods (open-telemetry#1136)
b0f978c 
Otherwise, they are no aligned together on godoc.

Co-authored-by: Tyler Yahn <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@rmfitzpatrick
fix invalid vault api deps (open-telemetry#1136)
1f9a135
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@vasireddy99
Improve the instructions for Bazel build. (open-telemetry#1136)
9dd3da3
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@TylerHelmuth
[collector] bump collector to v0.98.0 (open-telemetry#1136)
a688620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Beta 0.6.0
Development

No branches or pull requests
3 participants
@flands @kbrockhoff @tigrannajaryan