Remove configtest dependency from collector, generate tests in builder (

#4607)

Signed-off-by: Bogdan Drutu <[email protected]>

service/collector.go

@@ -85,10 +85,6 @@ type Collector struct {
 
 // New creates and returns a new instance of Collector.
 func New(set CollectorSettings) (*Collector, error) {
-	if err := validateConfigFromFactories(set.Factories); err != nil {
-		return nil, err
-	}
-
 	if set.ConfigProvider == nil {
 		return nil, errors.New("invalid nil config provider")
 	}

service/command_test.go

@@ -15,11 +15,15 @@
 package service
 
 import (
+	"context"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
+	"go.opentelemetry.io/collector/component"
+	"go.opentelemetry.io/collector/config"
+	"go.opentelemetry.io/collector/internal/internalinterface"
 	"go.opentelemetry.io/collector/internal/testcomponents"
 )
 
@@ -49,3 +53,24 @@ func TestNewCommandInvalidFactories(t *testing.T) {
 	err = cmd.Execute()
 	require.Error(t, err)
 }
+
+// badConfigExtensionFactory was created to force error path from factory returning
+// a config not satisfying the validation.
+type badConfigExtensionFactory struct {
+	internalinterface.BaseInternal
+}
+
+func (b badConfigExtensionFactory) Type() config.Type {
+	return "bad_config"
+}
+
+func (b badConfigExtensionFactory) CreateDefaultConfig() config.Extension {
+	return &struct {
+		config.ExtensionSettings
+		BadTagField int `mapstructure:"tag-with-dashes"`
+	}{}
+}
+
+func (b badConfigExtensionFactory) CreateExtension(_ context.Context, _ component.ExtensionCreateSettings, _ config.Extension) (component.Extension, error) {
+	return nil, nil
+}