Skip to content

Commit

Permalink
Apply @dmitryax feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
antonjim-te committed Sep 25, 2023
1 parent fcd2b83 commit ce3776a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .chloggen/SampledLoggerTelemetry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ issues: [8134]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: The sampled logger configuration can be disabled easily by setting the 'enabled' field to 'false'.
subtext: The sampled logger configuration can be disabled easily by setting the `service::telemetry::logs::sampling::enabled` to `false`.


# Optional: The change log or logs in which this entry should be included.
Expand Down
2 changes: 1 addition & 1 deletion service/telemetry/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ type LogsSamplingConfig struct {
Tick time.Duration `mapstructure:"tick"`
// Initial represents the first M messages logged each Tick.
Initial int `mapstructure:"initial"`
// Thereafter represents the N messages logged after Initial and the rest are dropped, during each Tick.
// Thereafter represents the sampling rate, every Nth message will be sampled after Initial messages are logged during each Tick.
// If Thereafter is zero, the logger will drop all the messages after the Initial each Tick.
Thereafter int `mapstructure:"thereafter"`
}
Expand Down

0 comments on commit ce3776a

Please sign in to comment.