Skip to content

Commit

Permalink
code review
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme committed Aug 1, 2024
1 parent 088ae1a commit a9fbae5
Showing 1 changed file with 17 additions and 14 deletions.
31 changes: 17 additions & 14 deletions config/configtelemetry/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
// It enables every component to have access to telemetry level
// to enable metrics only when necessary.
//
// This document provides guidance on which telemetry level to adopt for Collector metrics.
// When adopting a telemetry level, the developer is expected to rely on this guidance to
// justify their choice of telemetry level.
//
// 1. configtelemetry.None
//
// No telemetry data should be collected.
Expand All @@ -13,29 +17,28 @@
//
// Signals associated with this level cover the essential coverage of the component telemetry.
//
// This is the default level recommended when running the collector.
//
// The signals associated with this level must have low cardinality.
// This is the default level recommended when running the Collector.
//
// The signals associated with this level must represent a small data volume:
// - No more than 5 metrics reported.
// - At most 1 span actively recording simultaneously, covering the critical path.
// - At most 5 log records produced every 30s.
// Signals using this telemetry level can use this guidance:
// * The signals associated with this level must show low cardinality, the number of combinations of dimension values.
// * The signals associated with this level must represent a small data volume. Examples follow:
// - A max cardinality (total possible combinations of dimension values) of 50.
// - At most a span actively recording simultaneously, covering the critical path.
//
// Not all signals defined in the component telemetry are active.
// * Not all signals defined in the component telemetry are active.
//
// 3. configtelemetry.Normal
//
// Signals associated with this level cover the complete coverage of the component telemetry.
//
// The signals associated with this level must control cardinality.
//
// The signals associated with this level must represent a controlled data volume:
// - No more than 20 metrics reported.
// Signals using this telemetry level can use this guidance:
// - The signals associated with this level must control cardinality.
// It is acceptable at this level for cardinality to scale linearly with the monitored resources.
// - The signals associated with this level must represent a controlled data volume. Examples follow:
// - A max cardinality (total possible combinations of dimension values) of 500.
// - At most 5 spans actively recording simultaneously.
// - At most 20 log records produced every 30s.
//
// All signals defined in the component telemetry are active.
// * All signals defined in the component telemetry are active.
//
// 4. configtelemetry.Detailed
//
Expand Down

0 comments on commit a9fbae5

Please sign in to comment.