Skip to content

Commit

Permalink
Remove ballast flag, already no-op
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu committed Sep 10, 2021
1 parent 82d1af4 commit 7903bfc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 57 deletions.
8 changes: 0 additions & 8 deletions service/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import (
"go.opentelemetry.io/collector/extension/ballastextension"
"go.opentelemetry.io/collector/internal/collector/telemetry"
"go.opentelemetry.io/collector/service/internal"
"go.opentelemetry.io/collector/service/internal/builder"
"go.opentelemetry.io/collector/service/parserprovider"
)

Expand Down Expand Up @@ -151,7 +150,6 @@ func New(set CollectorSettings) (*Collector, error) {
configtelemetry.Flags,
parserprovider.Flags,
telemetry.Flags,
builder.Flags,
loggerFlags,
}
for _, addFlags := range addFlagsFns {
Expand Down Expand Up @@ -306,12 +304,6 @@ func (col *Collector) execute(ctx context.Context) error {
)
col.stateChannel <- Starting

// Add `mem-ballast-size-mib` warning message if it is still enabled
// TODO: will remove all `mem-ballast-size-mib` footprints after some baking time.
if builder.MemBallastSize() > 0 {
col.logger.Warn("`mem-ballast-size-mib` command line option has been deprecated. Please use `ballast extension` instead!")
}

col.asyncErrorChannel = make(chan error)

err := col.setupConfigurationComponents(ctx)
Expand Down
49 changes: 0 additions & 49 deletions service/internal/builder/builder.go

This file was deleted.

0 comments on commit 7903bfc

Please sign in to comment.