Skip to content

Commit

Permalink
Remove unnecessary exclude rules from golangci (#3441)
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu authored Jun 15, 2021
1 parent a1bd429 commit 0d94201
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
8 changes: 2 additions & 6 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,14 @@ issues:
linters:
# See https://github.com/golangci/golangci-lint/issues/537#issuecomment-545170007
- structcheck
- path: receiver/otlpreceiver/internal/marshal_jsonpb\.go
linters:
- gocritic
- gosimple
- text: "G404:"
linters:
- gosec
- text: "G402:"
linters:
- gosec
# Exclude internal and testbed packages for now.
- path: ".*internal.*|.*testbed.*"
# Exclude internal package for now.
- path: ".*internal.*"
text: "should have comment|should be of the form"
linters:
- revive
Expand Down
5 changes: 3 additions & 2 deletions testbed/testbed/test_bed.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ func SaveResults(resultsSummary TestResultsSummary) {

const testBedEnableEnvVarName = "RUN_TESTBED"

// GlobalConfig global config for testbed.
var GlobalConfig = struct {
// Relative path to default agent executable to test.
// DefaultAgentExeRelativeFile relative path to default agent executable to test.
// Can be set in the contrib repo to use a different executable name.
// Set this before calling DoTestMain().
//
Expand All @@ -58,7 +59,7 @@ var GlobalConfig = struct {
// that is passed to the TestCase.
DefaultAgentExeRelativeFile string
}{
// The default exe that is produced by Makefile "otelcol" target relative
// DefaultAgentExeRelativeFile the default exe that is produced by Makefile "otelcol" target relative
// to testbed/tests directory.
DefaultAgentExeRelativeFile: "../../bin/otelcol_{{.GOOS}}_{{.GOARCH}}",
}
Expand Down

0 comments on commit 0d94201

Please sign in to comment.