Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up default renovate config with regex to handle goreleaser-pro updates #728

Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 6, 2024

This PR takes the renovate config from https://github.com/open-telemetry/opentelemetry-collector (as I found this to be mostly also applicable here, maybe a bit overkill still) and adds a custom regex manager that handles updates of the version field for GoReleaser inside the goreleaser-action usages.
Example of an occurrence that this should cover:

- uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0
with:
distribution: goreleaser-pro
version: v2.3.2
workdir: distributions/${{ inputs.distribution }}
args: release --clean --split --timeout 2h --release-header-tmpl=../../.github/release-template.md

Hopefully, this works for #668 but renovate config updates are hard to test before merging. The local setup didn't scream, which is a good sign. I will close the issue manually once I'm sure that this PR fixes it and otherwise provide follow-up PRs.

@mowies mowies requested a review from a team as a code owner November 6, 2024 15:36
@mowies mowies requested a review from fatsheep9146 November 6, 2024 15:36
@mowies mowies changed the title Set up sensible default renovate config with extra regex to handle goreleaser-pro updates Set up default renovate config with regex to handle goreleaser-pro updates Nov 6, 2024
renovate.json Show resolved Hide resolved
@mowies mowies force-pushed the goreleaser-renovate branch from 039f056 to d7701bb Compare November 7, 2024 07:07
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, let's merge it and try it out!

@mx-psi mx-psi merged commit 067599e into open-telemetry:main Nov 7, 2024
3 checks passed
@mowies mowies deleted the goreleaser-renovate branch November 8, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants