Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin CI goreleaser version to v2.2.0 #667

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Sep 19, 2024

Version 2.3 of goreleaser changed some of the output directory names, making the Upload linux service packages task fail silently, causing the Package tests tasks to fail at retrieving the package artifacts under test.

This PR pins the version of goreleaser used in the CI to the previous one, v2.2.0, to resolve the issue.

We could also pin to v2.3 and update the expected directory name, but it seems that the name of output directories are not considered stable by goreleaser, so I think a better long-term solution is needed.

Version 2.3 of goreleaser changed some of the output directory names, making the `Upload linux service packages` task failing silently, causing the `Package tests` tasks to fail at retrieving the package artifacts under test.
@mx-psi
Copy link
Member

mx-psi commented Sep 19, 2024

I can merge this once it is marked as ready for review :)

@jade-guiton-dd jade-guiton-dd marked this pull request as ready for review September 19, 2024 12:35
@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner September 19, 2024 12:35
@mx-psi mx-psi merged commit befe950 into open-telemetry:main Sep 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants