Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackgopack4/go1.23 ci fix #641

Merged

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Aug 14, 2024

fixes failing ci tests now that repo has two tags associated with it.

Adds "Monorepo" tag in GoReleaser via the template go file.

Includes changes from #638

@jackgopack4 jackgopack4 marked this pull request as ready for review August 15, 2024 13:16
@jackgopack4 jackgopack4 requested review from a team and dashpole August 15, 2024 13:16
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackgopack4 does the k8s distro need a change to its goreleaser file? It is no managed by the cmd.

@jackgopack4
Copy link
Contributor Author

jackgopack4 commented Aug 15, 2024

@jackgopack4 does the k8s distro need a change to its goreleaser file? It is no managed by the cmd.

I added the monorepo tag manually in that goreleaser file in the last PR that was merged but didn't fix the issue for core and contrib

#640

@TylerHelmuth TylerHelmuth merged commit de92512 into open-telemetry:main Aug 15, 2024
36 checks passed
@jackgopack4 jackgopack4 deleted the jackgopack4/go1.23-ci-fix branch September 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants