Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some broken conditionals in pipelines #610

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix some broken conditionals in pipelines #610

merged 1 commit into from
Jul 29, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Jul 25, 2024 •
edited
Loading

This PR fixes some pipeline if conditionals that didn't work correctly.

@mowies mowies requested review from a team and mwear July 25, 2024 06:36
@mowies mowies mentioned this pull request Jul 25, 2024
Merged
@mx-psi mx-psi requested a review from pjanotti July 25, 2024 08:05
@mowies
Copy link
Member Author

mowies commented Jul 29, 2024

@mwear @pjanotti can we get this over the line? :)

@pjanotti
Copy link
Contributor

Hi @mowies - I approved it a few days back, but, I'm not a maintainer on this repo.

@mx-psi mx-psi merged commit a13cff5 into open-telemetry:main Jul 29, 2024
31 checks passed
@mowies mowies deleted the fix-pipeline-conditionals branch July 30, 2024 06:19
@mowies mowies mentioned this pull request Aug 27, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanotti pjanotti pjanotti approved these changes

@mx-psi mx-psi mx-psi approved these changes

@mwear mwear Awaiting requested review from mwear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mowies @pjanotti @mx-psi