Migrate ocb binary release to opentelemetry-collector-releases (see corresponding PR#10710 in opentelemetry-collector repo) #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgopack4
commented
Jul 24, 2024
jackgopack4
commented
Jul 24, 2024
|
rebased on upstream main following v0.106.0 release |
jackgopack4
force-pushed
the
main
branch
2 times, most recently
from
b3a9c87 to
629766b
Compare
jackgopack4
changed the title
evan-bradley
reviewed
Aug 2, 2024
This reverts commit be0e050.
mx-psi
approved these changes
Aug 6, 2024
evan-bradley
reviewed
Aug 6, 2024
evan-bradley
reviewed
Aug 6, 2024
frzifus
approved these changes
Aug 7, 2024
This reverts commit 7b935c0.
evan-bradley
approved these changes
Aug 7, 2024
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Aug 9, 2024
After discussion with the collector SIG call this week, July 31st, I have made small tweaks to the artifact release that will not require an "extra step" of pushing tags. If these changes are accepted, the distributions will be released under tag "vX.XXX.X" and the ocb binaries will be released under "cmd/builder/vX.XXX.X" but both under this repo, opentelemetry-collector-releases. The workflow `builder-release.yaml` in releases repo will push the additional tags necessary for the builder release. Refactoring the release process as mentioned in past issues/PRs. ocb binary is currently released in a separate release tag under this repository, which makes it harder to find and inconsistent with the rest of the binaries and images releasing in the opentelemetry-collector-releases repository. Releasing the ocb binaries in opentelemetry-collector-releases makes this process more standardized and also opens the opportunity to release more tools alongside ocb binary down the road, like corresponding docker images (as discussed in #5712). #### Link to tracking issue Fixes #10662 Mentioned in [releases issue # 295](open-telemetry/opentelemetry-collector-releases#295) [Corresponding PR in opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#608) #### Testing Sample binary release in [forked jackgopack4/opentelemetry-collector-releases repo](https://github.com/jackgopack4/opentelemetry-collector-releases/releases/tag/cmd%2Fbuilder%2Fv0.106.1) #### Documentation Updated corresponding documentation to reflect new release process --------- Co-authored-by: Pablo Baeyens <[email protected]>
dmitryax
approved these changes
Aug 9, 2024
This was referenced Aug 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: After discussion with the collector SIG call this week, July 31st, I have made small tweaks to the artifact release that will not require an "extra step" of pushing tags. If these changes are accepted, the distributions will be released under tag "vX.XXX.X" and the ocb binaries will be released under "cmd/builder/vX.XXX.X" but both under this repo, opentelemetry-collector-releases. The workflow
builder-release.yamlwill push the additional tags necessary for the builder release.Refactoring the release process as mentioned in past issues/PRs. ocb binary is currently released in a separate release tag under this repository, which makes it harder to find and inconsistent with the rest of the binaries and images releasing in the opentelemetry-collector-releases repository.
Releasing the ocb binaries in opentelemetry-collector-releases makes this process more standardized and also opens the opportunity to release more tools alongside ocb binary down the road, like corresponding docker images (as discussed in #5712).
Link to tracking issue
Fixes opentelemetry-collector # 10662
Prerequisite for issue #295
Corresponding PR in opentelemetry-collector
Testing
Sample binary release in forked jackgopack4/opentelemetry-collector-releases repo
Documentation
Updated corresponding documentation in opentelemetry-collector repository to reflect new release process