-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split goreleaser config file #485
Split goreleaser config file #485
Conversation
bba24cd
to
9680091
Compare
77c91b3
to
0b87eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before approving, let's discuss whether we are ready to remove the Go code that generates the goreleaser files: removing that code generator means we'll have to maintain those two YAML files. Adding cosign, for instance, would have required adding the same things on the two files.
I'm fine if we have a reason not to generate the goreleaser files, such as significant differences between the distributions.
lgtm |
@jpkrohling i think we could do the same approach you've done in your repo and auto generate the separate files. I was planning to do that in a future PR. |
Can you confirm how to run this locally? I tried the following, but it failed:
I also tried something closer to what we have in the CI files, but also failed:
|
if you are using the more up-to-date goreleaser you can update the --skip flags to use |
@jpkrohling I've never tried to run locally. We use goreleaser-pro in the repo and I don't have access locally. A lot of the features we use are pro features. Split and partial are specifically pro: https://goreleaser.com/customization/partial/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a .goreleaser at the root of the repository and needs to be removed.
This PR adds a distribution-specific
.goreleaser.yaml
file to each distribution and updates the ci to use these specific file.In the next PR I'll remove the auto-generated code, update the makefile, and remove the
.goreleaser.yaml
file that is at the root.Related to #429
Closes #487