Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split goreleaser config file #485

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Feb 21, 2024

This PR adds a distribution-specific .goreleaser.yaml file to each distribution and updates the ci to use these specific file.

In the next PR I'll remove the auto-generated code, update the makefile, and remove the .goreleaser.yaml file that is at the root.

Related to #429
Closes #487

@TylerHelmuth TylerHelmuth requested review from a team and jpkrohling February 21, 2024 18:29
@TylerHelmuth TylerHelmuth force-pushed the break-up-goreleaser-file branch 8 times, most recently from bba24cd to 9680091 Compare February 21, 2024 19:19
@TylerHelmuth TylerHelmuth force-pushed the break-up-goreleaser-file branch from 77c91b3 to 0b87eb3 Compare February 21, 2024 19:28
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before approving, let's discuss whether we are ready to remove the Go code that generates the goreleaser files: removing that code generator means we'll have to maintain those two YAML files. Adding cosign, for instance, would have required adding the same things on the two files.

I'm fine if we have a reason not to generate the goreleaser files, such as significant differences between the distributions.

@cpanato
Copy link
Contributor

cpanato commented Feb 22, 2024

lgtm

@TylerHelmuth
Copy link
Member Author

@jpkrohling i think we could do the same approach you've done in your repo and auto generate the separate files. I was planning to do that in a future PR.

jpkrohling
jpkrohling previously approved these changes Feb 22, 2024
@jpkrohling
Copy link
Member

Can you confirm how to run this locally? I tried the following, but it failed:

> goreleaser --snapshot --clean 
  • starting release...
  ⨯ release failed after 0s                  error=yaml: unmarshal errors:
  line 1: field partial not found in type config.Project

I also tried something closer to what we have in the CI files, but also failed:

> goreleaser --snapshot --clean --skip-sign --skip-sbom --timeout 2h --split --id otelcol
  ⨯ command failed                                   error=unknown flag: --split

@cpanato
Copy link
Contributor

cpanato commented Feb 22, 2024

if you are using the more up-to-date goreleaser you can update the --skip flags to use --skip=sign,sbom

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Feb 22, 2024

@jpkrohling I've never tried to run locally. We use goreleaser-pro in the repo and I don't have access locally. A lot of the features we use are pro features.

Split and partial are specifically pro: https://goreleaser.com/customization/partial/

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a .goreleaser at the root of the repository and needs to be removed.

.github/workflows/base-ci-goreleaser.yaml Show resolved Hide resolved
@jpkrohling jpkrohling dismissed their stale review February 23, 2024 08:41

stale review

@jpkrohling jpkrohling merged commit d98178e into open-telemetry:main Feb 23, 2024
27 checks passed
@TylerHelmuth TylerHelmuth deleted the break-up-goreleaser-file branch February 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.95.0 is missing otel-contrib rpm files
3 participants