Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly Mention Core Components #48

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Dec 18, 2021

  • Update distributions
    ** Add references to the core receivers, processors, extensions,
    exporters.
  • Add flag include_core to not use implicit mentions inclusion.
  • Minor indentation and spacing edits

Relates to open-telemetry/opentelemetry-collector#3927

Signed-off-by: Harold Dost [email protected]

@hdost hdost requested review from a team and bogdandrutu December 18, 2021 10:56
* Update distributions
** Add references to the core receivers, processors, extensions,
  exporters.
* Add flag `include_core` to not use implicit mentions inclusion.
* Minor indentation and spacing edits

Relates to open-telemetry/opentelemetry-collector#3927

Signed-off-by: Harold Dost <[email protected]>
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this PR!

@jpkrohling jpkrohling enabled auto-merge (squash) December 20, 2021 10:02
auto-merge was automatically disabled December 20, 2021 21:56

Head branch was pushed to by a user without write access

@hdost
Copy link
Contributor Author

hdost commented Dec 20, 2021

Maybe temporarily the requirement for GoReleaser can be changed? Either way https://github.com/hdost/testing-github-actions/pull/1/files << Might be a way that it could be changed for the future.

@jpkrohling
Copy link
Member

Maybe temporarily the requirement for GoReleaser can be changed?

Yes, the requirement is new and not fully tested :-) Given that there is a change to .goreleaser, it's correct that the "Check GoReleaser Configuration" workflow should be executed, no? If that was just part of a test and the actual PR won't have it, I'll disable this check permanently until we have something in place like your scratch branch.

@hdost
Copy link
Contributor Author

hdost commented Dec 21, 2021

Maybe temporarily the requirement for GoReleaser can be changed?

Yes, the requirement is new and not fully tested :-) Given that there is a change to .goreleaser, it's correct that the "Check GoReleaser Configuration" workflow should be executed, no? If that was just part of a test and the actual PR won't have it, I'll disable this check permanently until we have something in place like your scratch branch.

I'll remove it but i think you might have to trigger the workflows since I'm not a code owner

@jpkrohling
Copy link
Member

jpkrohling commented Dec 21, 2021

I'll remove it but i think you might have to trigger the workflows since I'm not a code owner

I removed the requirement, it should be fine to merge without triggering .goreleaser. It's optional because it takes a really long time (30m or so), which is not reasonable for changes not touching .goreleaser.yaml

@hdost
Copy link
Contributor Author

hdost commented Dec 21, 2021

Ok I've reverted the PR back to the originally approved change #48 (comment)

@jpkrohling jpkrohling enabled auto-merge (squash) December 21, 2021 09:06
@jpkrohling jpkrohling merged commit a83f3b4 into open-telemetry:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants