-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly Mention Core Components #48
Conversation
* Update distributions ** Add references to the core receivers, processors, extensions, exporters. * Add flag `include_core` to not use implicit mentions inclusion. * Minor indentation and spacing edits Relates to open-telemetry/opentelemetry-collector#3927 Signed-off-by: Harold Dost <[email protected]>
cf200d6
to
f2f04e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this PR!
Head branch was pushed to by a user without write access
f2f04e5
to
b9ca0c9
Compare
Maybe temporarily the requirement for GoReleaser can be changed? Either way https://github.com/hdost/testing-github-actions/pull/1/files << Might be a way that it could be changed for the future. |
Yes, the requirement is new and not fully tested :-) Given that there is a change to |
I'll remove it but i think you might have to trigger the workflows since I'm not a code owner |
I removed the requirement, it should be fine to merge without triggering .goreleaser. It's optional because it takes a really long time (30m or so), which is not reasonable for changes not touching .goreleaser.yaml |
b9ca0c9
to
f2f04e5
Compare
Ok I've reverted the PR back to the originally approved change #48 (comment) |
** Add references to the core receivers, processors, extensions,
exporters.
include_core
to not use implicit mentions inclusion.Relates to open-telemetry/opentelemetry-collector#3927
Signed-off-by: Harold Dost [email protected]