Add otelcol-contrib release #43

jpkrohling · 2021-12-15T12:37:50Z

Fixes #37

Signed-off-by: Juraci Paixão Kröhling [email protected]

Fixes open-telemetry#37 Signed-off-by: Juraci Paixão Kröhling <[email protected]>

jpkrohling · 2021-12-15T12:38:17Z

.goreleaser.yaml

@@ -6,6 +6,10 @@ archives:
    name_template: "{{ .Binary }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ if .Mips }}_{{ .Mips }}{{ end }}"
    builds:
      - "otelcol"
+  - id: "otelcol-contrib"


This file is auto-generated.

jpkrohling · 2021-12-15T12:39:02Z

configs/otelcol-contrib.yaml

@@ -0,0 +1,55 @@
+extensions:


This is a copy from the core's config. We do not currently ship contrib with a default config file, and I think this is a good opportunity to fix that.

jpkrohling · 2021-12-15T12:40:08Z

distributions/otelcol-contrib/manifest.yaml

+  otelcol_version: 0.41.0
+
+extensions:
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/asapauthextension v0.41.0


The components were obtained by a mix of sed and awk commands and I verified manually by counting the number of components. An extra pair of eyes won't hurt though.

Any thoughts on how to keep this list up to date in the future?

Manually reviewed the list and it looks good 👍

We are not going to have a components.go in the contrib anymore, so, changing the documentation to point to this instead of that would represent the current status. But the current status isn't good enough: I think we do have components that are ready but not included in the distribution.

I agree. It's confusing to have components in the repo, but not in the release without a more clear signal as to why that is... maybe we could start adding all components in this manifest, with the components that are not "ready" in a commented out section? This would at least give users looking for specific components a chance to discover why the component is not there themselves.

May I do this in a follow-up PR, if there are no other concerns?

works for me.

Here's the list of missing components:

Extensions - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/dockerobserver - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecstaskobserver Exporters - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/coralogixexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/observiqexporter Processors - github.com/open-telemetry/opentelemetry-collector-contrib/processor/redactionprocessor Receivers - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/apachereceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/cloudfoundryreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/googlecloudpubsubreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8seventsreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/mysqlreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/nginxreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver

jpkrohling · 2021-12-15T12:40:27Z

distributions/otelcol-contrib/manifest.yaml

+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/oidcauthextension v0.41.0
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.41.0
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage v0.41.0
+    import: github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage


This is the only component that deviates from the standards, and the builder was able to accommodate it.

jpkrohling · 2021-12-15T12:45:19Z

distributions/otelcol-contrib/otelcol-contrib.service

@@ -0,0 +1,15 @@
+[Unit]


I tested installing the RPM on a fresh Fedora 34 and verified that the systemd service was up and running.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

jpkrohling · 2021-12-15T14:13:47Z

This is currently failing with:

   ⨯ release failed after 2361.69s error=failed to build for linux_arm_6: exit status 2: # github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/hostmetadata
Error: /home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/[email protected]/internal/hostmetadata/host_linux.go:37:68: cannot use uname.Version[:] (type []uint8) as type []int8 in argument to int8ArrayToByteArray
Error: /home/runner/go/pkg/mod/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/[email protected]/internal/hostmetadata/host_linux.go:47:62: cannot use uname.Machine[:] (type []uint8) as type []int8 in argument to int8ArrayToByteArray

Recorded open-telemetry/opentelemetry-collector-contrib#6813 to track this. What should we do as a workaround? Remove this (and potentially others) component, or remove armv6 from the matrix?

codeboten · 2021-12-15T18:38:35Z

As discussed in the SIG call on Dev 15, it makes sense to remove armv6 for now to unblock this work.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

codeboten · 2021-12-16T16:24:04Z

distributions/otelcol-contrib/manifest.yaml

+  otelcol_version: 0.41.0
+
+extensions:
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/asapauthextension v0.41.0


works for me.

codeboten · 2021-12-16T16:24:57Z

distributions/otelcol-contrib/manifest.yaml

+  otelcol_version: 0.41.0
+
+extensions:
+  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/extension/asapauthextension v0.41.0


Here's the list of missing components:

Extensions - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/dockerobserver - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecstaskobserver Exporters - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/coralogixexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/observiqexporter Processors - github.com/open-telemetry/opentelemetry-collector-contrib/processor/redactionprocessor Receivers - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/apachereceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/cloudfoundryreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/googlecloudpubsubreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8seventsreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/mysqlreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/nginxreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver

Add otelcol-contrib release

c7e26ea

Fixes open-telemetry#37 Signed-off-by: Juraci Paixão Kröhling <[email protected]>

jpkrohling requested review from a team and bogdandrutu December 15, 2021 12:37

jpkrohling commented Dec 15, 2021

View reviewed changes

Increase timeout for goreleaser

9e27c20

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

codeboten self-assigned this Dec 15, 2021

Remove arches with problems building contrib

732dec7

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

codeboten approved these changes Dec 16, 2021

View reviewed changes

codeboten merged commit 5ddd7d9 into open-telemetry:main Dec 16, 2021

jpkrohling mentioned this pull request Dec 16, 2021

Add all missing components to the manifest, including the non-ready ones #46

Closed

silverlyra mentioned this pull request Jan 11, 2022

Build ARM64 Docker images #55

Merged

pellared mentioned this pull request Jan 17, 2022

Default config path changed in the contrib container image #59

Closed

jpkrohling deleted the jpkrohling/issue37 branch March 22, 2022 19:17

mx-psi mentioned this pull request Jun 3, 2022

distribution for arm7 #105

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add otelcol-contrib release #43

Add otelcol-contrib release #43

jpkrohling commented Dec 15, 2021

jpkrohling Dec 15, 2021

jpkrohling Dec 15, 2021

jpkrohling Dec 15, 2021

codeboten Dec 15, 2021

codeboten Dec 15, 2021

jpkrohling Dec 16, 2021

codeboten Dec 16, 2021

jpkrohling Dec 16, 2021

codeboten Dec 16, 2021

codeboten Dec 16, 2021

jpkrohling Dec 15, 2021

jpkrohling Dec 15, 2021

jpkrohling commented Dec 15, 2021

codeboten commented Dec 15, 2021

codeboten Dec 16, 2021

codeboten Dec 16, 2021

Add otelcol-contrib release #43

Add otelcol-contrib release #43

Conversation

jpkrohling commented Dec 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpkrohling commented Dec 15, 2021

codeboten commented Dec 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment