Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use env var for container base image name #23

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Use env var for container base image name #23

merged 1 commit into from
Oct 5, 2021

Conversation

jpkrohling
Copy link
Member

Fixes #22

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling
Use env var for container base image name
b8ae404 
Fixes #22

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested review from a team and owais October 4, 2021 08:58
mx-psi
mx-psi approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (although to be fair it is the first time I look at this repo so maybe you want some more experienced eyes looking at this too)

@jpkrohling
Copy link
Member Author

Thanks! I'll merge it, as the only way to really know whether it works is by merging and attempting a release.

@jpkrohling jpkrohling merged commit 926a0ba into open-telemetry:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@owais owais Awaiting requested review from owais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release fails as base container images are not using the new base name
2 participants
@jpkrohling @mx-psi