Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure configure command under cmd, remove public APIs #197

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and dashpole September 21, 2022 17:38
@bogdandrutu bogdandrutu force-pushed the restructure branch 2 times, most recently from 4e835fb to 2e41b93 Compare September 21, 2022 17:40
jpkrohling
jpkrohling previously approved these changes Sep 26, 2022
@jpkrohling jpkrohling dismissed their stale review September 26, 2022 18:19

Should the go.sum have been removed?

@bogdandrutu
Copy link
Member Author

Should the go.sum have been removed?

Not sure, the file is not removed, only lots of deletes, but I am not sure why, I run go mod tidy -compat=1.18.

@jpkrohling jpkrohling merged commit 060efe3 into open-telemetry:main Sep 27, 2022
@bogdandrutu bogdandrutu deleted the restructure branch September 29, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants