Update to v0.59.0 #188
Merged
Update to v0.59.0 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony J Mirabella <[email protected]>
jpkrohling
reviewed
Aug 31, 2022
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/wavefrontreceiver v0.59.0 | ||
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsperfcountersreceiver v0.59.0 | ||
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zipkinreceiver v0.59.0 | ||
| - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zookeeperreceiver v0.59.0 | ||
|
|
||
| # When adding a replace, add a comment before it to document why it's needed and when it can be removed | ||
| replaces: |
There was a problem hiding this comment.
An exercise we run during the release is whether we still need the replaces statements here. Do you think we still need the ones we have here?
There was a problem hiding this comment.
Not sure I can make a call on either of these. The gnostic issue is still open and people are still reporting issues, so probably safest to leave it. The go-connections link I don't have enough context to follow. @jamesmoessis or @MovieStoreGuy may be able to provide more details.
Since these are both versioned replacements it should be safe to leave them until the creator weighs in on their removal since the won't take effect if a newer version would be selected.
Signed-off-by: Anthony J Mirabella <[email protected]>
bogdandrutu
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony J Mirabella [email protected]