[pkg/stanza] Initialize with log-collection as a subtree #9922

djaglowski · 2022-05-10T18:43:23Z

This also temporarily excludes pkg/stanza from several validation checks. Checklist for reverting those changes:

Remove exclusion from Makefile's ALL_MODULES
Remove exclusion from .github/workflows/scripts/check-collector-module-version.sh's mod_files
Remove exclusion from versions.yaml

* flatten syslog input config

* Add some golden config tests to file_input operator

* makefile add check/add license feature

* file_input add mapstructure support Co-authored-by: Daniel Jaglowski <[email protected]>

* Add additional golden config test cases to file_input

* Change entry.Labels to entry.Attributes

* Remove unused packages * Remove separate module for k8sevent input

* Update changelog ahead of v0.16.0 release

* Require a namespace when using offsets database This is necessary in order to allow multiple pipelines to run in the same process without being at risk of overwriting offsets.

* Add mapstructure tests to Bytesize type

* Add mapstructure support to parsers

* Add mapstructure support and expand test cases

#60) * use opentelemetry collect standard tls config instead of tc tls config

* fix golang ci yaml and improve makefile

* eventLog add mapstructure support

* journalinput config support mapstructure

* Add golden config tests

)

The default value of parse_to was changed at the same time that some new tests were added to the regex parser. The new tests did not account for this, but no merge conflict existed.

* Update changelog ahead of v0.29.0 release * Add upgrade guide to changelog

* Minor cleanup in docs * Remove whitespace and move pipeline into types dir * Whitespace in pipeline.md

* Complete removal of preserve_to setting * Retain parse_from field in sub-parsers

* Update regex_parser docs * Update regex_parser.md

* initial commit * added separate fields for RenderingInfo and EventData * changed xml.go to only populate output with necessary fields

Makefile.Common

mx-psi

I didn't participate on the previous "move git history across repos" efforts, but this looks sensible to me. I think we should create an issue for follow-up steps. Also, I left a comment about when do we want to remove/move files related to Github Actions pipelines for log-collection

mx-psi · 2022-05-11T10:03:16Z

pkg/stanza/.github/codecov.yaml

@@ -0,0 +1,24 @@
+codecov:


Will this and other .github configuration files be removed in a follow-up PR?

Yes, definitely. My next PR will be to do exactly that.

I've created #9960 as an aggregate tracking issue.

djaglowski · 2022-05-11T14:13:59Z

#9946 should be decided on before this PR is merged, since this PR includes that change.

pmm-sumo

Impressive collection of commits

bogdandrutu · 2022-05-11T19:37:09Z

@djaglowski you need to manually cleanup all the commits (the last once) since we want to do a "merge" not squash commit and all commits will be kept forever. I think you can at least start by dropping the impi merge, and ping on this issue when list is clean.

git-subtree-dir: pkg/stanza git-subtree-mainline: 03b33c3 git-subtree-split: c912ec5

djaglowski · 2022-05-11T21:46:06Z

@bogdandrutu, this should be good to go now, if you want to have another look.

wph95 and others added 30 commits March 3, 2021 08:58

syslog_input config embed syslog_parser inline (#43)

fb7443a

* flatten syslog input config

Add copyright to files added in PR 24 (#38)

163e1a8

Golden config pattern (#40)

453b2c3

* Add some golden config tests to file_input operator

makefile add check/add license feature (#47)

fa642e3

* makefile add check/add license feature

file_input add mapstructure support (#25)

c20a108

* file_input add mapstructure support Co-authored-by: Daniel Jaglowski <[email protected]>

Added Golden Configs for "file_input" operator (#48)

6cb613e

* Add additional golden config test cases to file_input

Change entry.Labels to entry.Attributes (#51)

e784ee6

* Change entry.Labels to entry.Attributes

Cleanup packages (#53)

a404a3a

* Remove unused packages * Remove separate module for k8sevent input

Update changelog ahead of v0.16.0 release (#54)

0c7c5c5

* Update changelog ahead of v0.16.0 release

Require a namespace when using offsets database (#55)

07e6901

* Require a namespace when using offsets database This is necessary in order to allow multiple pipelines to run in the same process without being at risk of overwriting offsets.

Add mapstructure unmarshalling to bytesize type (#56)

83ae561

* Add mapstructure tests to Bytesize type

all builtin parser add mapstructure support (#58)

a7b781e

* Add mapstructure support to parsers

Add mapstructure support and expand test cases for "Duration" type (#57)

61f2a8b

* Add mapstructure support and expand test cases

use opentelemetry collect standard tls config instead of tc tls config (

aa8d825

#60) * use opentelemetry collect standard tls config instead of tc tls config

fix golang ci yaml and improve makefile (#61)

81f80e6

* fix golang ci yaml and improve makefile

window_event_input config add mapstructure support (#62)

eb3a760

* eventLog add mapstructure support

Json golden Config unmarshalling (#64)

7439d24

Add regex parser golden configs (#65)

02bb510

Add more test cases (#66)

ba9cb46

Router golden config testing (#69)

0576b45

add journal_input support mapstructure (#63)

e03f95d

* journalinput config support mapstructure

Add golden config tests to severity operator (#71)

2d9f6f0

* Add golden config tests

Update Router doc to reflect default field change (#70)

ba8a43d

Add golden config testing to time (#72)

0f6b1a9

Rename 'label' to 'attributes' (#82)

8f9be2c

golangci enable gci (#74)

0356f77

Update README.md (#86)

a32c088

Rename record to body (#88)

51eca70

Support whole number float64 type for severity parsing (#90)

e63fbfe

Add trace attributes and parser (trace_id, span_id and trace_flags) (#76

37eb654

)

djaglowski and others added 6 commits April 8, 2022 15:43

Fix issue introduced by interaction between two recent PRs (#467)

fccb9c1

The default value of parse_to was changed at the same time that some new tests were added to the regex parser. The new tests did not account for this, but no merge conflict existed.

Update changelog ahead of v0.29.0 release (#466)

86992df

* Update changelog ahead of v0.29.0 release * Add upgrade guide to changelog

Minor cleanup in docs (#469)

7fec6a4

* Minor cleanup in docs * Remove whitespace and move pipeline into types dir * Whitespace in pipeline.md

Patch v0.29.1 - Properly remove "preserve_to" setting (#468)

70fe7c7

* Complete removal of preserve_to setting * Retain parse_from field in sub-parsers

Update regex_parser docs (#479)

b6b247e

* Update regex_parser docs * Update regex_parser.md

Windows input fix (#478)

c912ec5

* initial commit * added separate fields for RenderingInfo and EventData * changed xml.go to only populate output with necessary fields

djaglowski mentioned this pull request May 10, 2022

[tooling/impi] Evaluate packages of current module only #9946

Merged

djaglowski commented May 10, 2022

View reviewed changes

Makefile.Common Outdated Show resolved Hide resolved

djaglowski marked this pull request as ready for review May 10, 2022 21:43

djaglowski requested review from a team and mx-psi May 10, 2022 21:43

github-actions bot assigned mx-psi May 10, 2022

mx-psi approved these changes May 11, 2022

View reviewed changes

This was referenced May 11, 2022

[pkg/stanza] Rename module in files #9954

Closed

[pkg/stanza] Remove pkg/stanza/internal/tools module #9955

Closed

[pkg/stanza] Replace dependency on log-collection in components #9956

Closed

pmm-sumo approved these changes May 11, 2022

View reviewed changes

djaglowski added 2 commits May 11, 2022 16:32

Add 'pkg/stanza/' from commit 'c912ec5cdb776ada95f4f06fd97d1e315f07fe14'

1ecbef4

git-subtree-dir: pkg/stanza git-subtree-mainline: 03b33c3 git-subtree-split: c912ec5

[pkg/stanza] Apply porto, exclude module from other checks

c9b6347

djaglowski force-pushed the pkg-stanza-subtree branch from 8bf4841 to c9b6347 Compare May 11, 2022 20:38

bogdandrutu merged commit e8ed9c1 into open-telemetry:main May 12, 2022

djaglowski deleted the pkg-stanza-subtree branch May 12, 2022 15:06

djaglowski mentioned this pull request May 13, 2022

Proposal to merge opentelemetry-log-collection #8850

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pkg/stanza] Initialize with log-collection as a subtree #9922

[pkg/stanza] Initialize with log-collection as a subtree #9922

djaglowski commented May 10, 2022 •

edited

Loading

mx-psi left a comment

mx-psi May 11, 2022

djaglowski May 11, 2022

djaglowski May 11, 2022

djaglowski commented May 11, 2022

pmm-sumo left a comment

bogdandrutu commented May 11, 2022

djaglowski commented May 11, 2022

[pkg/stanza] Initialize with log-collection as a subtree #9922

[pkg/stanza] Initialize with log-collection as a subtree #9922

Conversation

djaglowski commented May 10, 2022 • edited Loading

mx-psi left a comment

Choose a reason for hiding this comment

mx-psi May 11, 2022

Choose a reason for hiding this comment

djaglowski May 11, 2022

Choose a reason for hiding this comment

djaglowski May 11, 2022

Choose a reason for hiding this comment

djaglowski commented May 11, 2022

pmm-sumo left a comment

Choose a reason for hiding this comment

bogdandrutu commented May 11, 2022

djaglowski commented May 11, 2022

djaglowski commented May 10, 2022 •

edited

Loading