Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt dynamic docker stats functionality #958

Merged
merged 7 commits into from
Sep 15, 2020
Merged

Adopt dynamic docker stats functionality #958

merged 7 commits into from
Sep 15, 2020

Conversation

rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick commented Sep 4, 2020

Description:
Adding a feature - Adds a core docker event loop to allow the collector to monitor docker stats for containers that were not running during the initialization of the receiver. Also sources the docker stats receiver as a top level component.

Link to tracking Issue: resolves #957

Testing: Includes additional unit and integration tests. Also adds a remove container feature to the test container helpers to assist in verifying dynamic container monitoring.

Documentation: will add to changelog

@rmfitzpatrick rmfitzpatrick requested a review from a team September 4, 2020 22:34
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #958 into master will increase coverage by 13.92%.
The diff coverage is 95.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #958       +/-   ##
===========================================
+ Coverage   74.88%   88.80%   +13.92%     
===========================================
  Files          21      249      +228     
  Lines        1071    13355    +12284     
===========================================
+ Hits          802    11860    +11058     
- Misses        213     1142      +929     
- Partials       56      353      +297     
Flag Coverage Δ
#integration 76.39% <84.93%> (+1.50%) ⬆️
#unit 87.82% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/dockerstatsreceiver/docker.go 92.93% <94.23%> (+20.00%) ⬆️
internal/common/testing/container/container.go 78.02% <100.00%> (+4.21%) ⬆️
receiver/dockerstatsreceiver/receiver.go 97.10% <100.00%> (+12.02%) ⬆️
.../kubeletstatsreceiver/kubelet/metadata_provider.go 100.00% <0.00%> (ø)
...sformprocessor/operation_aggregate_label_values.go 100.00% <0.00%> (ø)
receiver/carbonreceiver/reporter.go 86.84% <0.00%> (ø)
extension/jmxmetricsextension/extension.go 100.00% <0.00%> (ø)
.../awsxrayreceiver/internal/translator/translator.go 100.00% <0.00%> (ø)
...rcedetectionprocessor/internal/gcp/gce/metadata.go 100.00% <0.00%> (ø)
processor/k8sprocessor/factory.go 100.00% <0.00%> (ø)
... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182227a...935d904. Read the comment docs.

@rmfitzpatrick
Copy link
Contributor Author

Load test failures shouldn't be relevant to these changes.

@tigrannajaryan
Copy link
Member

@bogdandrutu assigned to you since you already reviewed.

receiver/dockerstatsreceiver/docker.go Show resolved Hide resolved
receiver/dockerstatsreceiver/docker.go Show resolved Hide resolved
receiver/dockerstatsreceiver/docker.go Outdated Show resolved Hide resolved
receiver/dockerstatsreceiver/docker.go Outdated Show resolved Hide resolved
receiver/dockerstatsreceiver/docker.go Show resolved Hide resolved
receiver/dockerstatsreceiver/docker.go Show resolved Hide resolved
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bogdandrutu you had comments, are you OK to merge or you still have questions?

@bogdandrutu
Copy link
Member

@tigrannajaryan my main concerns were addressed, I had not look in more details but I trust you did :)

@rmfitzpatrick
Copy link
Contributor Author

@tigrannajaryan is this ok to land?

@tigrannajaryan tigrannajaryan merged commit 326f19b into open-telemetry:master Sep 15, 2020
@rmfitzpatrick rmfitzpatrick deleted the dynamic_docker_stats branch September 15, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Stats Receiver is not enabled
3 participants