-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt dynamic docker stats functionality #958
Adopt dynamic docker stats functionality #958
Conversation
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
===========================================
+ Coverage 74.88% 88.80% +13.92%
===========================================
Files 21 249 +228
Lines 1071 13355 +12284
===========================================
+ Hits 802 11860 +11058
- Misses 213 1142 +929
- Partials 56 353 +297
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Load test failures shouldn't be relevant to these changes. |
@bogdandrutu assigned to you since you already reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@bogdandrutu you had comments, are you OK to merge or you still have questions?
@tigrannajaryan my main concerns were addressed, I had not look in more details but I trust you did :) |
@tigrannajaryan is this ok to land? |
Description:
Adding a feature - Adds a core docker event loop to allow the collector to monitor docker stats for containers that were not running during the initialization of the receiver.
Also sources the docker stats receiver as a top level component.Link to tracking Issue:
resolves #957Testing: Includes additional unit and integration tests. Also adds a remove container feature to the test container helpers to assist in verifying dynamic container monitoring.
Documentation: will add to changelog